[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Review Request: Ensure main.qml presence in decoration kcm
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-08-17 19:22:15
Message-ID: 20120817192215.19123.73997 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106062/
-----------------------------------------------------------
Review request for kwin and Martin Gräßlin.
Description
-------
This handles it gracefully.
Given the kcm is usually in and will crash systemsettings i've a slight tendency \
towards this but would also be fine with an assert (or straight abort regardless of \
compile mode)
Ratio:
The code relies on the presence of an extern resource and produces "funny" crashes if \
absent - that somebody has to investigate.
I also propose to check kwin for similar hard deps on extern resources and handle \
them in a common way.
This addresses bug 304881.
http://bugs.kde.org/show_bug.cgi?id=304881
Diffs
-----
kwin/kcmkwin/kwindecoration/kwindecoration.h 07d84f6
kwin/kcmkwin/kwindecoration/kwindecoration.cpp 1f7a209
Diff: http://git.reviewboard.kde.org/r/106062/diff/
Testing
-------
Yes, deleted main.qml -> crash.
W/ patch I get an ugly label telling me that i shall contact my distro because an \
important file is missing.
Thanks,
Thomas Lübking
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106062/">http://git.reviewboard.kde.org/r/106062/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This handles it gracefully. Given the kcm is usually in and will crash \
systemsettings i've a slight tendency towards this but would also be fine with an \
assert (or straight abort regardless of compile mode)
Ratio:
The code relies on the presence of an extern resource and produces "funny" \
crashes if absent - that somebody has to investigate.
I also propose to check kwin for similar hard deps on extern resources and handle \
them in a common way.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, deleted main.qml -> crash. W/ patch I get an ugly label telling \
me that i shall contact my distro because an important file is missing.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304881">304881</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwindecoration/kwindecoration.h <span style="color: \
grey">(07d84f6)</span></li>
<li>kwin/kcmkwin/kwindecoration/kwindecoration.cpp <span style="color: \
grey">(1f7a209)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106062/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic