'Re: Review Request: Ensure that titleHeight is at least height of buttons'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Ensure that titleHeight is at least height of buttons
From:       "Commit Hook" <null () kde ! org>
Date:       2012-08-17 18:37:40
Message-ID: 20120817183740.14857.26316 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105937/#review17619
-----------------------------------------------------------

This review has been submitted with commit beaf0e633577ce4c3bc9ac1b0834167bd9c7922e \
by Martin Gräßlin to branch KDE/4.9.

- Commit Hook

On Aug. 8, 2012, 9:15 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105937/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 9:15 p.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> Ensure that titleHeight is at least height of buttons
> 
> Required to properly lay out the title in case of vertical or
> bottom alignment.
> 
> BUG: 304822
> FIXED-IN: 4.9.1
> 
> 
> This addresses bug 304822.
> http://bugs.kde.org/show_bug.cgi?id=304822
> 
> 
> Diffs
> -----
> 
> kwin/clients/aurorae/src/qml/aurorae.qml f1538736eb9a25d7afef275f5d4a4aed07286862 
> 
> Diff: http://git.reviewboard.kde.org/r/105937/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105937/">http://git.reviewboard.kde.org/r/105937/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit beaf0e633577ce4c3bc9ac1b0834167bd9c7922e by Martin Gräßlin to \
branch KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 8th, 2012, 9:15 p.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 8, 2012, 9:15 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ensure that titleHeight is at least height of buttons

Required to properly lay out the title in case of vertical or
bottom alignment.

BUG: 304822
FIXED-IN: 4.9.1</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=304822">304822</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/clients/aurorae/src/qml/aurorae.qml <span style="color: \
grey">(f1538736eb9a25d7afef275f5d4a4aed07286862)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105937/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 