[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: introduce KDecorationPlugins::canLoad so we don't mess up our plugins on reload
From: "Commit Hook" <null () kde ! org>
Date: 2012-07-22 9:35:12
Message-ID: 20120722093512.14835.33580 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105499/#review16199
-----------------------------------------------------------
This review has been submitted with commit b61024cc848d4e3d623408ed0b02c3500922fecc \
by Thomas Lübking to branch KDE/4.9.
- Commit Hook
On July 21, 2012, 9:13 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105499/
> -----------------------------------------------------------
>
> (Updated July 21, 2012, 9:13 p.m.)
>
>
> Review request for kwin, Alex Fiestas and Martin Gräßlin.
>
>
> Description
> -------
>
> ok, second try (f*** reviewboard)
> - plugins get messed up on "load to test whether this works" -> we get a dangeling \
> fact pointer
> - storing the current plugin and loading it after the find loop finished didn't \
> help
> - options for r2
> * skip testing
> * don't destroyPrevious after the test load (leaks but works)
> * use this patch
>
> for 4.9 i'd like to invoke canLoad in load but it's too late for tonight
>
>
> This addresses bug 303247.
> http://bugs.kde.org/show_bug.cgi?id=303247
>
>
> Diffs
> -----
>
> kwin/kcmkwin/kwindecoration/decorationmodel.cpp b945606
> kwin/libkdecorations/kdecoration_plugins_p.h 27873ef
> kwin/libkdecorations/kdecoration_plugins_p.cpp 04df26e
>
> Diff: http://git.reviewboard.kde.org/r/105499/diff/
>
>
> Testing
> -------
>
> yes, no longer crash
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105499/">http://git.reviewboard.kde.org/r/105499/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit b61024cc848d4e3d623408ed0b02c3500922fecc by Thomas Lübking to \
branch KDE/4.9.</pre> <br />
<p>- Commit</p>
<br />
<p>On July 21st, 2012, 9:13 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Alex Fiestas and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated July 21, 2012, 9:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ok, second try (f*** reviewboard)
- plugins get messed up on "load to test whether this works" -> we get a \
dangeling fact pointer
- storing the current plugin and loading it after the find loop finished didn't \
help
- options for r2
* skip testing
* don't destroyPrevious after the test load (leaks but works)
* use this patch
for 4.9 i'd like to invoke canLoad in load but it's too late for \
tonight</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, no longer crash</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=303247">303247</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kcmkwin/kwindecoration/decorationmodel.cpp <span style="color: \
grey">(b945606)</span></li>
<li>kwin/libkdecorations/kdecoration_plugins_p.h <span style="color: \
grey">(27873ef)</span></li>
<li>kwin/libkdecorations/kdecoration_plugins_p.cpp <span style="color: \
grey">(04df26e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105499/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic