'Re: Review Request: Plasmate: Add KWin Scripting support to the startpage'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Plasmate: Add KWin Scripting support to the startpage
From:       "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date:       2012-06-21 6:52:34
Message-ID: 20120621065234.28555.58843 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105238/
-----------------------------------------------------------

(Updated June 21, 2012, 6:52 a.m.)

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

Changes
-------

In this patch i have fix the issues that they been pointed out by Martin

Description
-------

Hello,

This is the task of the 4th week of my GSoC.
In this patch i am adding a new entry to the starpage of the plasmate for t=
he KWin Scripting.

ISSUES:

1)in the "showInteractiveKWinConsole", the icon of the application is the "=
plasma", but i guess that we don't want the plasma icon for the effects.
Any suggestions?
2)I have not add a QML template for scripting because i cannot find one. Do=
 you know if there is any?

Diffs (updated)
-----

  editors/metadata/metadataeditor.cpp 3fe79c2 =

  mainwindow.cpp 6e48940 =

  startpage.h 3ae94c4 =

  startpage.cpp bc333d4 =

  templates/CMakeLists.txt 043eeb8 =

  templates/mainKWinScript.js PRE-CREATION =

Diff: http://git.reviewboard.kde.org/r/105238/diff/

Testing
-------

Thanks,

Antonis Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105238/">http://git.reviewboard.kde.org/r/105238/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Antonis Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated June 21, 2012, 6:52 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In this patch i have fix the issues that they been pointed out by \
Martin</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,

This is the task of the 4th week of my GSoC.
In this patch i am adding a new entry to the starpage of the plasmate for the KWin \
Scripting.

ISSUES:

1)in the &quot;showInteractiveKWinConsole&quot;, the icon of the application is the \
&quot;plasma&quot;, but i guess that we don&#39;t want the plasma icon for the \
effects. Any suggestions?
2)I have not add a QML template for scripting because i cannot find one. Do you know \
if there is any?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>editors/metadata/metadataeditor.cpp <span style="color: \
grey">(3fe79c2)</span></li>

 <li>mainwindow.cpp <span style="color: grey">(6e48940)</span></li>

 <li>startpage.h <span style="color: grey">(3ae94c4)</span></li>

 <li>startpage.cpp <span style="color: grey">(bc333d4)</span></li>

 <li>templates/CMakeLists.txt <span style="color: grey">(043eeb8)</span></li>

 <li>templates/mainKWinScript.js <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105238/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 