[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Plasmate: Add KWin Scripting support to the startpage
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-06-19 18:43:27
Message-ID: 20120619184327.29454.11103 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 18, 2012, 8:04 p.m., Martin Gräßlin wrote:
> > startpage.cpp, line 147
> > <http://git.reviewboard.kde.org/r/105238/diff/1/?file=67483#file67483line147>
> >
> > sure you want to use a plasma icon?
>
> Antonis Tsiapaliokas wrote:
> No, we don't. I have put this only for the compile. As i said above, i cannot find \
> the correct icon. Any ideas?
what do you think about preferences-system-windows-actions?
> On June 18, 2012, 8:04 p.m., Martin Gräßlin wrote:
> > templates/mainKWinScript.js, line 19
> > <http://git.reviewboard.kde.org/r/105238/diff/1/?file=67485#file67485line19>
> >
> > we have a few examples in kde-examples. Maybe something from there might be a \
> > better template.
> > Also it might be nice to add a comment with link to documentation into the \
> > template.
>
> Antonis Tsiapaliokas wrote:
> You mean this one?
>
> http://techbase.kde.org/Development/Tutorials/KWin/Scripting
>
>
yes as a link to the tutorial, plus a link to the API docs.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105238/#review14858
-----------------------------------------------------------
On June 13, 2012, 9:12 a.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105238/
> -----------------------------------------------------------
>
> (Updated June 13, 2012, 9:12 a.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> Hello,
>
> This is the task of the 4th week of my GSoC.
> In this patch i am adding a new entry to the starpage of the plasmate for the KWin \
> Scripting.
> ISSUES:
>
> 1)in the "showInteractiveKWinConsole", the icon of the application is the "plasma", \
> but i guess that we don't want the plasma icon for the effects. Any suggestions?
> 2)I have not add a QML template for scripting because i cannot find one. Do you \
> know if there is any?
>
> Diffs
> -----
>
> editors/metadata/metadataeditor.cpp 3fe79c2
> mainwindow.cpp 6e48940
> startpage.h 3ae94c4
> startpage.cpp bc333d4
> templates/CMakeLists.txt 043eeb8
> templates/mainKWinScript.js PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/105238/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105238/">http://git.reviewboard.kde.org/r/105238/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 18th, 2012, 8:04 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105238/diff/1/?file=67483#file67483line147" \
style="color: black; font-weight: bold; text-decoration: \
underline;">startpage.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
StartPage::setupWidgets()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">147</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">new</span> <span class="n">QListWidgetItem</span><span \
class="p">(</span><span class="n">KIcon</span><span class="p">(</span><span \
class="s">"application-x-plasma"</span><span class="p">),</span> <span \
class="n">i18n</span><span class="p">(</span><span class="s">"KWin \
Script"</span><span class="p">),</span> <span class="n">m_ui</span><span \
class="p">.</span><span class="n">contentTypes</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sure you want to use a \
plasma icon?</pre> </blockquote>
<p>On June 19th, 2012, 8:53 a.m., <b>Antonis Tsiapaliokas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, we don't. I have \
put this only for the compile. As i said above, i cannot find the correct icon. Any \
ideas?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what do you \
think about preferences-system-windows-actions?</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 18th, 2012, 8:04 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105238/diff/1/?file=67485#file67485line19" \
style="color: black; font-weight: bold; text-decoration: \
underline;">templates/mainKWinScript.js</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">19</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kd">function</span> <span class="nx">isVideoPlayer</span><span \
class="p">(</span><span class="nx">client</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">we have a few examples \
in kde-examples. Maybe something from there might be a better template.
Also it might be nice to add a comment with link to documentation into the \
template.</pre> </blockquote>
<p>On June 19th, 2012, 8:53 a.m., <b>Antonis Tsiapaliokas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You mean this one?
http://techbase.kde.org/Development/Tutorials/KWin/Scripting
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes as a \
link to the tutorial, plus a link to the API docs.</pre> <br />
<p>- Martin</p>
<br />
<p>On June 13th, 2012, 9:12 a.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated June 13, 2012, 9:12 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
This is the task of the 4th week of my GSoC.
In this patch i am adding a new entry to the starpage of the plasmate for the KWin \
Scripting.
ISSUES:
1)in the "showInteractiveKWinConsole", the icon of the application is the \
"plasma", but i guess that we don't want the plasma icon for the \
effects. Any suggestions?
2)I have not add a QML template for scripting because i cannot find one. Do you know \
if there is any?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>editors/metadata/metadataeditor.cpp <span style="color: \
grey">(3fe79c2)</span></li>
<li>mainwindow.cpp <span style="color: grey">(6e48940)</span></li>
<li>startpage.h <span style="color: grey">(3ae94c4)</span></li>
<li>startpage.cpp <span style="color: grey">(bc333d4)</span></li>
<li>templates/CMakeLists.txt <span style="color: grey">(043eeb8)</span></li>
<li>templates/mainKWinScript.js <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105238/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic