[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Drop kephal dependency from KWin
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-03-27 20:27:53
Message-ID: 20120327202753.5120.62649 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 27, 2012, 5:21 p.m., Martin Gräßlin wrote:
> > kwin/geometry.cpp, lines 299-302
> > <http://git.reviewboard.kde.org/r/104427/diff/1/?file=55025#file55025line299>
> >
> > after thinking about it I could not see any difference any more. In both cases \
> > the complete display is returned.
>
> Thomas Lübking wrote:
> Pot. related to how many screens kephal sees in the multihead (maybe even xinerama \
> instead xrandr?) case. If it sees the "other" screen as well, desktopGeometry() \
> would largely differ from screenGeomtry() but latter be equal to \
> display(Width|Height)()
> So by dropping kephal, this pitfall could have implicitly be avoided.
> -> Did you test on a multihead config (i'm tonight not in the mood to break my \
> setup ;-)
of course I did not test on multihead. But my old laptop has a xorg.conf prepared for \
multihead and I could run a recompile there.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104427/#review11912
-----------------------------------------------------------
On March 27, 2012, 5:19 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104427/
> -----------------------------------------------------------
>
> (Updated March 27, 2012, 5:19 p.m.)
>
>
> Review request for kwin and Alex Fiestas.
>
>
> Description
> -------
>
> Kephal has turned into not being more than a wrapper around QDesktopWidget and does \
> not even provide syntax sugar.
>
> Diffs
> -----
>
> kwin/CMakeLists.txt 463692d
> kwin/effects/screenshot/screenshot.h f05d0ec
> kwin/events.cpp 30350aa
> kwin/geometry.cpp 5c176b7
> kwin/kcmkwin/kwinoptions/CMakeLists.txt 319ab47
> kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
> kwin/kcmkwin/kwintabbox/CMakeLists.txt 42c0a00
> kwin/libkdecorations/CMakeLists.txt 739698e
> kwin/libkdecorations/kcommondecoration.cpp 02a33e9
> kwin/libkwineffects/CMakeLists.txt 9cd2a6b
> kwin/options.cpp 717a82d
> kwin/scene.cpp 4e69121
> kwin/screenedge.cpp 0b57185
> kwin/tabbox/declarative.cpp c8abf60
> kwin/workspace.cpp 5542a3d
>
> Diff: http://git.reviewboard.kde.org/r/104427/diff/
>
>
> Testing
> -------
>
> currently running kwin without kephal on a multiscreen setup - so far everything's \
> fine.
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104427/">http://git.reviewboard.kde.org/r/104427/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 27th, 2012, 5:21 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104427/diff/1/?file=55025#file55025line299" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/geometry.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QRect \
Workspace::clientArea(clientAreaOption opt, int screen, int desktop) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">292</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">is_multihead</span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">298</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span \
class="n">QRect</span><span class="p">(</span><span class="mi">0</span><span \
class="p">,</span> <span class="mi">0</span><span class="p">,</span> <span \
class="n">displayWidth</span><span class="p">(),</span> <span \
class="n">displayHeight</span><span class="p">());</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">293</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="n">Kephal</span><span class="o">::</span><span \
class="n">ScreenUtils</span><span class="o">::</span><span \
class="n">screenGeometry</span><span class="p">(</span><span \
class="n">screen_number</span><span class="p">);</span></pre></td> <th \
bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">294</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">else</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">295</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="n">Kephal</span><span class="o">::</span><span \
class="n">ScreenUtils</span><span class="o">::</span><span \
class="n">desktopGeometry</span><span class="p">();</span></pre></td> <th \
bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">after thinking about it \
I could not see any difference any more. In both cases the complete display is \
returned.</pre> </blockquote>
<p>On March 27th, 2012, 7:39 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pot. related to how many \
screens kephal sees in the multihead (maybe even xinerama instead xrandr?) case. If \
it sees the "other" screen as well, desktopGeometry() would largely differ \
from screenGeomtry() but latter be equal to display(Width|Height)()
So by dropping kephal, this pitfall could have implicitly be avoided.
-> Did you test on a multihead config (i'm tonight not in the mood to break my \
setup ;-)</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">of course I \
did not test on multihead. But my old laptop has a xorg.conf prepared for multihead \
and I could run a recompile there.</pre> <br />
<p>- Martin</p>
<br />
<p>On March 27th, 2012, 5:19 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Alex Fiestas.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 27, 2012, 5:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Kephal has turned into not being more than a wrapper around \
QDesktopWidget and does not even provide syntax sugar.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">currently running kwin without kephal on a multiscreen setup - so far \
everything's fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/CMakeLists.txt <span style="color: grey">(463692d)</span></li>
<li>kwin/effects/screenshot/screenshot.h <span style="color: \
grey">(f05d0ec)</span></li>
<li>kwin/events.cpp <span style="color: grey">(30350aa)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(5c176b7)</span></li>
<li>kwin/kcmkwin/kwinoptions/CMakeLists.txt <span style="color: \
grey">(319ab47)</span></li>
<li>kwin/kcmkwin/kwinoptions/windows.cpp <span style="color: \
grey">(30c94c0)</span></li>
<li>kwin/kcmkwin/kwintabbox/CMakeLists.txt <span style="color: \
grey">(42c0a00)</span></li>
<li>kwin/libkdecorations/CMakeLists.txt <span style="color: \
grey">(739698e)</span></li>
<li>kwin/libkdecorations/kcommondecoration.cpp <span style="color: \
grey">(02a33e9)</span></li>
<li>kwin/libkwineffects/CMakeLists.txt <span style="color: \
grey">(9cd2a6b)</span></li>
<li>kwin/options.cpp <span style="color: grey">(717a82d)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(4e69121)</span></li>
<li>kwin/screenedge.cpp <span style="color: grey">(0b57185)</span></li>
<li>kwin/tabbox/declarative.cpp <span style="color: grey">(c8abf60)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(5542a3d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104427/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic