--===============3925746036288288767== Content-Type: multipart/alternative; boundary="===============4599913010327079498==" --===============4599913010327079498== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On March 27, 2012, 5:21 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > > kwin/geometry.cpp, lines 299-302 > > > > > > after thinking about it I could not see any difference any more. In= both cases the complete display is returned. > = > Thomas L=C3=BCbking wrote: > Pot. related to how many screens kephal sees in the multihead (maybe = even xinerama instead xrandr?) case. > If it sees the "other" screen as well, desktopGeometry() would largel= y differ from screenGeomtry() but latter be equal to display(Width|Height)() > = > So by dropping kephal, this pitfall could have implicitly be avoided. > -> Did you test on a multihead config (i'm tonight not in the mood to= break my setup ;-) of course I did not test on multihead. But my old laptop has a xorg.conf pr= epared for multihead and I could run a recompile there. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104427/#review11912 ----------------------------------------------------------- On March 27, 2012, 5:19 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104427/ > ----------------------------------------------------------- > = > (Updated March 27, 2012, 5:19 p.m.) > = > = > Review request for kwin and Alex Fiestas. > = > = > Description > ------- > = > Kephal has turned into not being more than a wrapper around QDesktopWidge= t and does not even provide syntax sugar. > = > = > Diffs > ----- > = > kwin/CMakeLists.txt 463692d = > kwin/effects/screenshot/screenshot.h f05d0ec = > kwin/events.cpp 30350aa = > kwin/geometry.cpp 5c176b7 = > kwin/kcmkwin/kwinoptions/CMakeLists.txt 319ab47 = > kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0 = > kwin/kcmkwin/kwintabbox/CMakeLists.txt 42c0a00 = > kwin/libkdecorations/CMakeLists.txt 739698e = > kwin/libkdecorations/kcommondecoration.cpp 02a33e9 = > kwin/libkwineffects/CMakeLists.txt 9cd2a6b = > kwin/options.cpp 717a82d = > kwin/scene.cpp 4e69121 = > kwin/screenedge.cpp 0b57185 = > kwin/tabbox/declarative.cpp c8abf60 = > kwin/workspace.cpp 5542a3d = > = > Diff: http://git.reviewboard.kde.org/r/104427/diff/ > = > = > Testing > ------- > = > currently running kwin without kephal on a multiscreen setup - so far eve= rything's fine. > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============4599913010327079498== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104427/

On March 27th, 2012, 5:21 p.m., Martin Gr= =C3=A4=C3=9Flin wrote:

= = = = =

kwin/geometry.cpp (Diff revision 1)
QRect Workspace::clientArea(clientAreaOption opt, int screen, int d= esktop) const
292	if (is_multihead)	298	return QRect(0, 0,= displayWidth(), <= span class=3D"n">displayHeight());
293	return Kephal::S= creenUtils::screenGeometr= y(screen_number);
294	else
295	return Kephal::S= creenUtils::desktopGeomet= ry();

after thi=
nking about it I could not see any difference any more. In both cases the c=
omplete display is returned.

On March 27th, 2012, 7:39 p.m., Thomas L=C3=BCbking wrote:

Pot. rela=
ted to how many screens kephal sees in the multihead (maybe even xinerama i=
nstead xrandr?) case.
If it sees the "other" screen as well, desktopGeometry() would la=
rgely differ from screenGeomtry() but latter be equal to display(Width|Heig=
ht)()

So by dropping kephal, this pitfall could have implicitly be avoided.
-> Did you test on a multihead config (i'm tonight not in the mood t=
o break my setup ;-)

of course I did not test on multihead. But my old laptop has a xorg.=
conf prepared for multihead and I could run a recompile there.

- Martin

On March 27th, 2012, 5:19 p.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin and Alex Fiestas.

By Martin Gr=C3=A4=C3=9Flin.

Updated March 27, 2012, 5:19 p.m.

Descripti= on

Kephal has turned into not being more than a wrapper around =
QDesktopWidget and does not even provide syntax sugar.

Testing <= /h1>

currently running kwin without kephal on a multiscreen setup=
 - so far everything's fine.

Diffs=

kwin/CMakeLists.txt (463692d)
kwin/effects/screenshot/screenshot.h (f05d= 0ec)
kwin/events.cpp (30350aa)
kwin/geometry.cpp (5c176b7)
kwin/kcmkwin/kwinoptions/CMakeLists.txt (3= 19ab47)
kwin/kcmkwin/kwinoptions/windows.cpp (30c9= 4c0)
kwin/kcmkwin/kwintabbox/CMakeLists.txt (42= c0a00)
kwin/libkdecorations/CMakeLists.txt (73969= 8e)
kwin/libkdecorations/kcommondecoration.cpp (02a33e9)
kwin/libkwineffects/CMakeLists.txt (9cd2a6= b)
kwin/options.cpp (717a82d)
kwin/scene.cpp (4e69121)
kwin/screenedge.cpp (0b57185)
kwin/tabbox/declarative.cpp (c8abf60)
kwin/workspace.cpp (5542a3d)

--===============4599913010327079498==-- --===============3925746036288288767== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============3925746036288288767==--