[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Add appmenu support to kwin
From: Bellegarde_Cédric <gnumdk () gmail ! com>
Date: 2012-03-27 17:58:55
Message-ID: 20120327175855.28527.84057 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 27, 2012, 2:03 p.m., Bellegarde Cédric wrote:
> > Diff r6 also add:
> > - Kded module with renamed importer class
> > - KDE_BUILD_KAPPMENU build option
>
> Thomas Lübking wrote:
> did you give a ship it to yourself?
> i doubt that's the point about review requests...
>
> Martin Gräßlin wrote:
> concerning ship its... here we need two, one from KWin and one from Oxygen.
No i wanted to add a comment to diff6... And i just understanded what "Ship it" \
mean...
- Bellegarde
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review11908
-----------------------------------------------------------
On March 27, 2012, 2 p.m., Bellegarde Cédric wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104344/
> -----------------------------------------------------------
>
> (Updated March 27, 2012, 2 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Here a patch to add appmenu support to kwin:
> - via a menu button in titlebar
> - via a global shortcut
>
> Works by Lionel Chauvin and me, original review request: \
> https://git.reviewboard.kde.org/r/101162/
> It depends on:
> http://quickgit.kde.org/index.php?p=kded-appmenu.git
>
> Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
> http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
>
> It looks like this:
> http://www.youtube.com/watch?v=j0o1sRLRc60&hd=1
>
> I remove ( http://kde-look.org/CONTENT/content-pre1/141254-1.png ) this way to show \
> menu button because:
> - It conflicts with window menu button
> - Using application name is impossible (we only have window class and sometime it's \
> quite ugly)
> - Using just "Menu" really looks bad
>
>
> Diffs
> -----
>
> CMakeLists.txt c766fdf
> appmenu/CMakeLists.txt PRE-CREATION
> appmenu/lib/CMakeLists.txt PRE-CREATION
> appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
> appmenu/lib/importer_interface.h PRE-CREATION
> appmenu/lib/importer_interface.cpp PRE-CREATION
> appmenu/lib/kappmenu_export.h PRE-CREATION
> appmenu/lib/kappmenuimporter.h PRE-CREATION
> appmenu/lib/kappmenuimporter.cpp PRE-CREATION
> appmenu/lib/menuinfo.h PRE-CREATION
> appmenu/module/CMakeLists.txt PRE-CREATION
> appmenu/module/appmenu.h PRE-CREATION
> appmenu/module/appmenu.cpp PRE-CREATION
> appmenu/module/appmenu.desktop PRE-CREATION
> appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
> appmenu/module/registrar.h PRE-CREATION
> appmenu/module/registrar.cpp PRE-CREATION
> kwin/CMakeLists.txt 463692d
> kwin/bridge.h 64108e5
> kwin/bridge.cpp 897d432
> kwin/client.h c35643f
> kwin/client.cpp 8ff98c6
> kwin/clients/oxygen/oxygenbutton.h ea11717
> kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
> kwin/clients/oxygen/oxygenclient.h e1d1d0a
> kwin/clients/oxygen/oxygenclient.cpp 7a2b021
> kwin/clients/oxygen/oxygenfactory.h b38b097
> kwin/clients/oxygen/oxygenfactory.cpp 827aa59
> kwin/config-kwin.h.cmake 8893fa4
> kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
> kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
> kwin/kcmkwin/kwindecoration/preview.h 20ee869
> kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
> kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
> kwin/kcmkwin/kwinoptions/windows.cpp 30c94c0
> kwin/kwin.kcfg cf6537e
> kwin/kwinbindings.cpp 3284cf0
> kwin/libkdecorations/kcommondecoration.h 3fe9fcf
> kwin/libkdecorations/kcommondecoration.cpp 02a33e9
> kwin/libkdecorations/kdecoration.h 442d0a1
> kwin/libkdecorations/kdecoration.cpp 71f4f8d
> kwin/libkdecorations/kdecorationbridge.h b7d0619
> kwin/menubar.h PRE-CREATION
> kwin/menubar.cpp PRE-CREATION
> kwin/options.h 855ed78
> kwin/options.cpp 717a82d
> kwin/scripting/workspace_wrapper.h c4ea8f6
> kwin/scripting/workspace_wrapper.cpp c0de078
> kwin/useractions.cpp 120481b
> kwin/workspace.h 1c6a831
> kwin/workspace.cpp 5542a3d
>
> Diff: http://git.reviewboard.kde.org/r/104344/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bellegarde Cédric
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104344/">http://git.reviewboard.kde.org/r/104344/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 27th, 2012, 2:03 p.m., <b>Bellegarde \
Cédric</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Diff r6 also add:
- Kded module with renamed importer class
- KDE_BUILD_KAPPMENU build option</pre>
</blockquote>
<p>On March 27th, 2012, 5:22 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">did you give a ship it \
to yourself? i doubt that's the point about review requests...</pre>
</blockquote>
<p>On March 27th, 2012, 5:28 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">concerning ship its... \
here we need two, one from KWin and one from Oxygen.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No i wanted to add a \
comment to diff6... And i just understanded what "Ship it" mean...</pre> \
<br />
<p>- Bellegarde</p>
<br />
<p>On March 27th, 2012, 2 p.m., Bellegarde Cédric wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Bellegarde Cédric.</div>
<p style="color: grey;"><i>Updated March 27, 2012, 2 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: \
https://git.reviewboard.kde.org/r/101162/
It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git
Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
It looks like this:
http://www.youtube.com/watch?v=j0o1sRLRc60&hd=1
I remove ( http://kde-look.org/CONTENT/content-pre1/141254-1.png ) this way to show \
menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime \
it's quite ugly)
- Using just "Menu" really looks bad</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(c766fdf)</span></li>
<li>appmenu/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/com.canonical.AppMenu.Registrar.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/importer_interface.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/importer_interface.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/kappmenu_export.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/kappmenuimporter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/kappmenuimporter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/menuinfo.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>appmenu/module/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/module/appmenu.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>appmenu/module/appmenu.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>appmenu/module/appmenu.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/module/com.canonical.AppMenu.Registrar.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/module/registrar.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>appmenu/module/registrar.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/CMakeLists.txt <span style="color: grey">(463692d)</span></li>
<li>kwin/bridge.h <span style="color: grey">(64108e5)</span></li>
<li>kwin/bridge.cpp <span style="color: grey">(897d432)</span></li>
<li>kwin/client.h <span style="color: grey">(c35643f)</span></li>
<li>kwin/client.cpp <span style="color: grey">(8ff98c6)</span></li>
<li>kwin/clients/oxygen/oxygenbutton.h <span style="color: \
grey">(ea11717)</span></li>
<li>kwin/clients/oxygen/oxygenbutton.cpp <span style="color: \
grey">(28aa8b1)</span></li>
<li>kwin/clients/oxygen/oxygenclient.h <span style="color: \
grey">(e1d1d0a)</span></li>
<li>kwin/clients/oxygen/oxygenclient.cpp <span style="color: \
grey">(7a2b021)</span></li>
<li>kwin/clients/oxygen/oxygenfactory.h <span style="color: \
grey">(b38b097)</span></li>
<li>kwin/clients/oxygen/oxygenfactory.cpp <span style="color: \
grey">(827aa59)</span></li>
<li>kwin/config-kwin.h.cmake <span style="color: grey">(8893fa4)</span></li>
<li>kwin/kcmkwin/kwindecoration/CMakeLists.txt <span style="color: \
grey">(4762bb9)</span></li>
<li>kwin/kcmkwin/kwindecoration/buttons.cpp <span style="color: \
grey">(2d12244)</span></li>
<li>kwin/kcmkwin/kwindecoration/preview.h <span style="color: \
grey">(20ee869)</span></li>
<li>kwin/kcmkwin/kwindecoration/preview.cpp <span style="color: \
grey">(fe802c7)</span></li>
<li>kwin/kcmkwin/kwinoptions/windows.h <span style="color: \
grey">(3fadf2c)</span></li>
<li>kwin/kcmkwin/kwinoptions/windows.cpp <span style="color: \
grey">(30c94c0)</span></li>
<li>kwin/kwin.kcfg <span style="color: grey">(cf6537e)</span></li>
<li>kwin/kwinbindings.cpp <span style="color: grey">(3284cf0)</span></li>
<li>kwin/libkdecorations/kcommondecoration.h <span style="color: \
grey">(3fe9fcf)</span></li>
<li>kwin/libkdecorations/kcommondecoration.cpp <span style="color: \
grey">(02a33e9)</span></li>
<li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(442d0a1)</span></li>
<li>kwin/libkdecorations/kdecoration.cpp <span style="color: \
grey">(71f4f8d)</span></li>
<li>kwin/libkdecorations/kdecorationbridge.h <span style="color: \
grey">(b7d0619)</span></li>
<li>kwin/menubar.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/menubar.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/options.h <span style="color: grey">(855ed78)</span></li>
<li>kwin/options.cpp <span style="color: grey">(717a82d)</span></li>
<li>kwin/scripting/workspace_wrapper.h <span style="color: \
grey">(c4ea8f6)</span></li>
<li>kwin/scripting/workspace_wrapper.cpp <span style="color: \
grey">(c0de078)</span></li>
<li>kwin/useractions.cpp <span style="color: grey">(120481b)</span></li>
<li>kwin/workspace.h <span style="color: grey">(1c6a831)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(5542a3d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104344/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic