This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104344/

On March 27th, 2012, 2:03 p.m., Bellegarde Cédric wrote:

Diff r6 also add:
- Kded module with renamed importer class
- KDE_BUILD_KAPPMENU build option

On March 27th, 2012, 5:22 p.m., Thomas Lübking wrote:

did you give a ship it to yourself?
i doubt that's the point about review requests...

On March 27th, 2012, 5:28 p.m., Martin Gräßlin wrote:

concerning ship its... here we need two, one from KWin and one from Oxygen.
No i wanted to add a comment to diff6... And i just understanded what "Ship it" mean...

- Bellegarde


On March 27th, 2012, 2 p.m., Bellegarde Cédric wrote:

Review request for kwin.
By Bellegarde Cédric.

Updated March 27, 2012, 2 p.m.

Description 

Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut

Works by Lionel Chauvin and me, original review request: https://git.reviewboard.kde.org/r/101162/

It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git

Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583

It looks like this:
http://www.youtube.com/watch?v=j0o1sRLRc60&hd=1

I remove ( http://kde-look.org/CONTENT/content-pre1/141254-1.png ) this way to show menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime it's quite ugly)
- Using just "Menu" really looks bad

Diffs

  • CMakeLists.txt (c766fdf)
  • appmenu/CMakeLists.txt (PRE-CREATION)
  • appmenu/lib/CMakeLists.txt (PRE-CREATION)
  • appmenu/lib/com.canonical.AppMenu.Registrar.xml (PRE-CREATION)
  • appmenu/lib/importer_interface.h (PRE-CREATION)
  • appmenu/lib/importer_interface.cpp (PRE-CREATION)
  • appmenu/lib/kappmenu_export.h (PRE-CREATION)
  • appmenu/lib/kappmenuimporter.h (PRE-CREATION)
  • appmenu/lib/kappmenuimporter.cpp (PRE-CREATION)
  • appmenu/lib/menuinfo.h (PRE-CREATION)
  • appmenu/module/CMakeLists.txt (PRE-CREATION)
  • appmenu/module/appmenu.h (PRE-CREATION)
  • appmenu/module/appmenu.cpp (PRE-CREATION)
  • appmenu/module/appmenu.desktop (PRE-CREATION)
  • appmenu/module/com.canonical.AppMenu.Registrar.xml (PRE-CREATION)
  • appmenu/module/registrar.h (PRE-CREATION)
  • appmenu/module/registrar.cpp (PRE-CREATION)
  • kwin/CMakeLists.txt (463692d)
  • kwin/bridge.h (64108e5)
  • kwin/bridge.cpp (897d432)
  • kwin/client.h (c35643f)
  • kwin/client.cpp (8ff98c6)
  • kwin/clients/oxygen/oxygenbutton.h (ea11717)
  • kwin/clients/oxygen/oxygenbutton.cpp (28aa8b1)
  • kwin/clients/oxygen/oxygenclient.h (e1d1d0a)
  • kwin/clients/oxygen/oxygenclient.cpp (7a2b021)
  • kwin/clients/oxygen/oxygenfactory.h (b38b097)
  • kwin/clients/oxygen/oxygenfactory.cpp (827aa59)
  • kwin/config-kwin.h.cmake (8893fa4)
  • kwin/kcmkwin/kwindecoration/CMakeLists.txt (4762bb9)
  • kwin/kcmkwin/kwindecoration/buttons.cpp (2d12244)
  • kwin/kcmkwin/kwindecoration/preview.h (20ee869)
  • kwin/kcmkwin/kwindecoration/preview.cpp (fe802c7)
  • kwin/kcmkwin/kwinoptions/windows.h (3fadf2c)
  • kwin/kcmkwin/kwinoptions/windows.cpp (30c94c0)
  • kwin/kwin.kcfg (cf6537e)
  • kwin/kwinbindings.cpp (3284cf0)
  • kwin/libkdecorations/kcommondecoration.h (3fe9fcf)
  • kwin/libkdecorations/kcommondecoration.cpp (02a33e9)
  • kwin/libkdecorations/kdecoration.h (442d0a1)
  • kwin/libkdecorations/kdecoration.cpp (71f4f8d)
  • kwin/libkdecorations/kdecorationbridge.h (b7d0619)
  • kwin/menubar.h (PRE-CREATION)
  • kwin/menubar.cpp (PRE-CREATION)
  • kwin/options.h (855ed78)
  • kwin/options.cpp (717a82d)
  • kwin/scripting/workspace_wrapper.h (c4ea8f6)
  • kwin/scripting/workspace_wrapper.cpp (c0de078)
  • kwin/useractions.cpp (120481b)
  • kwin/workspace.h (1c6a831)
  • kwin/workspace.cpp (5542a3d)

View Diff