[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: raise window during shade hover
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-03-22 23:40:13
Message-ID: 20120322234013.10465.92925 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104280/
-----------------------------------------------------------
(Updated March 22, 2012, 11:40 p.m.)
Review request for kwin and Martin Gräßlin.
Changes
-------
bleh - i forgot to publish my reply.
in short: i wasn't all happy with the patch because windows were unconditionally \
restacked and also if the shade_below client actually was no normal window (but a \
dock or so) the window was put to the bottom of the stack.
Both is addressed.
Also there's a second commit in the updated diff which prevents moving windows from \
hover unshading, what causes geometry corruptions (the window is resized to a \
vertical minimum)
I'll wait 3 days for a veto a push on sunday - or a a previous "re-ship it"
Description
-------
see description
This addresses bug 281435.
http://bugs.kde.org/show_bug.cgi?id=281435
Diffs (updated)
-----
kwin/client.h c35643f
kwin/client.cpp 8ff98c6
kwin/activation.cpp 91b1a1b
Diff: http://git.reviewboard.kde.org/r/104280/diff/
Testing
-------
window raises on hovering and stacks back when re-shading
Thanks,
Thomas Lübking
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104280/">http://git.reviewboard.kde.org/r/104280/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 22, 2012, 11:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">bleh - i forgot to publish my reply. in short: i wasn't all happy \
with the patch because windows were unconditionally restacked and also if the \
shade_below client actually was no normal window (but a dock or so) the window was \
put to the bottom of the stack.
Both is addressed.
Also there's a second commit in the updated diff which prevents moving windows \
from hover unshading, what causes geometry corruptions (the window is resized to a \
vertical minimum)
I'll wait 3 days for a veto a push on sunday - or a a previous "re-ship \
it"</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see description</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">window raises on hovering and stacks back when re-shading</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=281435">281435</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.h <span style="color: grey">(c35643f)</span></li>
<li>kwin/client.cpp <span style="color: grey">(8ff98c6)</span></li>
<li>kwin/activation.cpp <span style="color: grey">(91b1a1b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104280/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic