'Re: Review Request: support tabbing in directional window switching & sync max. and tiling state'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: support tabbing in directional window switching & sync max. and tiling state
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-03-22 21:55:30
Message-ID: 20120322215530.5918.44838 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104293/#review11772
-----------------------------------------------------------

kwin/geometry.cpp
<http://git.reviewboard.kde.org/r/104293/#comment9335>

    I shall maybe #undef them at the end before pushing.

- Thomas Lübking

On March 22, 2012, 9:53 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104293/
> -----------------------------------------------------------
> 
> (Updated March 22, 2012, 9:53 p.m.)
> 
> 
> Review request for kwin and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> see summary & bugs
> 
> 
> This addresses bugs 296096 and 296097.
>     http://bugs.kde.org/show_bug.cgi?id=296096
>     http://bugs.kde.org/show_bug.cgi?id=296097
> 
> 
> Diffs
> -----
> 
>   kwin/client.h c35643f 
>   kwin/client.cpp 8ff98c6 
>   kwin/geometry.cpp 5c176b7 
>   kwin/layers.cpp ed8555c 
>   kwin/tabgroup.h c02e1a2 
>   kwin/tabgroup.cpp 355c139 
>   kwin/useractions.cpp dfb6fd4 
> 
> Diff: http://git.reviewboard.kde.org/r/104293/diff/
> 
> 
> Testing
> -------
> 
> yes.
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104293/">http://git.reviewboard.kde.org/r/104293/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/104293/diff/4/?file=54311#file54311line2084" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/geometry.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">if (tabGroup()) { \</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2081</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#define BLOCK_TABS if (tabGroup()) \
tabGroup()-&gt;blockStateUpdates(true);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I shall \
maybe #undef them at the end before pushing.</pre> </div>
<br />

<p>- Thomas</p>

<br />
<p>On March 22nd, 2012, 9:53 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated March 22, 2012, 9:53 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see summary &amp; bugs</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=296096">296096</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=296097">296097</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.h <span style="color: grey">(c35643f)</span></li>

 <li>kwin/client.cpp <span style="color: grey">(8ff98c6)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(5c176b7)</span></li>

 <li>kwin/layers.cpp <span style="color: grey">(ed8555c)</span></li>

 <li>kwin/tabgroup.h <span style="color: grey">(c02e1a2)</span></li>

 <li>kwin/tabgroup.cpp <span style="color: grey">(355c139)</span></li>

 <li>kwin/useractions.cpp <span style="color: grey">(dfb6fd4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104293/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 