'Re: Review Request: [Janitorial] Remove unused resetMaximize function'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: [Janitorial] Remove unused resetMaximize function
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-03-22 17:22:21
Message-ID: 20120322172221.23709.9781 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On March 22, 2012, 6:51 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > do I see correctly that the method was not called at all? *sigh*

i guess it used to be called - probably before the separate vertical/horizo=
ntal maximization was added. *shrug*
But yes, it's bit rot.

- Thomas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104276/#review11735
-----------------------------------------------------------

On March 14, 2012, 8:20 p.m., Thomas L=C3=BCbking wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104276/
> -----------------------------------------------------------
> =

> (Updated March 14, 2012, 8:20 p.m.)
> =

> =

> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =

> =

> Description
> -------
> =

> handled by changeMaximize since probably kwin supports maximization flags
> =

> =

> Diffs
> -----
> =

>   kwin/client.h b394687 =

>   kwin/geometry.cpp e37a93d =

> =

> Diff: http://git.reviewboard.kde.org/r/104276/diff/
> =

> =

> Testing
> -------
> =

> still compiles and runs
> =

> =

> Thanks,
> =

> Thomas L=C3=BCbking
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104276/">http://git.reviewboard.kde.org/r/104276/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 22nd, 2012, 6:51 a.m., <b>Martin \
Gräßlin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">do I see correctly that the method was not called at all? *sigh*</pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i guess it used to be \
called - probably before the separate vertical/horizontal maximization was added. \
*shrug* But yes, it&#39;s bit rot.</pre>
<br />

<p>- Thomas</p>

<br />
<p>On March 14th, 2012, 8:20 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated March 14, 2012, 8:20 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">handled by changeMaximize since probably kwin supports maximization \
flags</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">still compiles and runs</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.h <span style="color: grey">(b394687)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(e37a93d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104276/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 