[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: present windows, don't highlight window after loosing mouse (but in tabbox mode)
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-03-22 17:18:18
Message-ID: 20120322171818.23422.27227 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 22, 2012, 6:54 a.m., Martin Gräßlin wrote:
> > kwin/effects/presentwindows/presentwindows.cpp, lines 558-559
> > <http://git.reviewboard.kde.org/r/104264/diff/1/?file=53049#file53049line558>
> >
> > do you want to remove the tabBox case due to my review to remove the code?
The behavior would be weird as long as the effect is used as tabbox - so rather not \
for 4.8 but for 4.9 the patches have to be aligned (obviously i can't check a member \
that's not present ;-)
-> either i wait until you've pushed the tabbox change or you've to update that \
patch.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104264/#review11736
-----------------------------------------------------------
On March 13, 2012, 9:20 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104264/
> -----------------------------------------------------------
>
> (Updated March 13, 2012, 9:20 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> as mentioned in the bug this patch binds the highlighted window to the mouse
>
> (minor) regression?:
> in doubt no window is initially selected (in non tabbox mode), esp. not when mouse \
> triggered.
>
> Diffs
> -----
>
> kwin/effects/presentwindows/presentwindows.cpp 039f84b
>
> Diff: http://git.reviewboard.kde.org/r/104264/diff/
>
>
> Testing
> -------
>
> yes, works - the null case is guarded, since now the relative window is in doubt \
> the first one.
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104264/">http://git.reviewboard.kde.org/r/104264/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 22nd, 2012, 6:54 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104264/diff/1/?file=53049#file53049line558" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/presentwindows/presentwindows.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PresentWindowsEffect::windowInputMouseEvent(Window w, QEvent *e)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">558</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="p">(</span><span class="n">hovering</span> <span class="o">||</span> <span \
class="n">m_tabBoxEnabled</span><span class="p">))</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">559</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">setHighlightedWindow</span><span class="p">(</span><span \
class="nb">NULL</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">do you want to remove \
the tabBox case due to my review to remove the code?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The \
behavior would be weird as long as the effect is used as tabbox - so rather not for \
4.8 but for 4.9 the patches have to be aligned (obviously i can't check a member \
that's not present ;-)
-> either i wait until you've pushed the tabbox change or you've to update \
that patch.</pre> <br />
<p>- Thomas</p>
<br />
<p>On March 13th, 2012, 9:20 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 13, 2012, 9:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">as mentioned in the bug this patch binds the highlighted window to the \
mouse
(minor) regression?:
in doubt no window is initially selected (in non tabbox mode), esp. not when mouse \
triggered.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, works - the null case is guarded, since now the relative window is \
in doubt the first one.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(039f84b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104264/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic