[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: split decorationRect & visibleRect usage
From: "Commit Hook" <null () kde ! org>
Date: 2012-03-20 23:44:46
Message-ID: 20120320234446.13966.7874 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104215/#review11678
-----------------------------------------------------------
This review has been submitted with commit 3737f8c578405f7eb0c0a48bd69febd7=
5420060e by Thomas L=C3=BCbking to branch master.
- Commit Hook
On March 14, 2012, 1:12 a.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104215/
> -----------------------------------------------------------
> =
> (Updated March 14, 2012, 1:12 a.m.)
> =
> =
> Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Hugo Pereira Da Cos=
ta.
> =
> =
> Description
> -------
> =
> This fixes the absent decoration for GL and new shadows by clearly separa=
ting visibleRect and decorationRect usage, where decorationRect only handle=
s the decoration while visibleRect handles repaints.
> =
> This patch is against 4.8 and must likely be handported to 4.9 for the la=
yer repaints (alongside shadows and animationeffect ...)
> =
> =
> Diffs
> -----
> =
> kwin/client.cpp 22aa8dc =
> kwin/composite.cpp 55a7144 =
> kwin/deleted.cpp e166bf1 =
> kwin/geometry.cpp 49ddd29 =
> kwin/scene.cpp 0541198 =
> kwin/scene_xrender.h 23ff2ad =
> kwin/scene_xrender.cpp b2a11c8 =
> kwin/toplevel.cpp 0716c2f =
> =
> Diff: http://git.reviewboard.kde.org/r/104215/diff/
> =
> =
> Testing
> -------
> =
> oxygen (w/ padding) and bespin (w/ new shadows) on xrender and opengl bac=
kend
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104215/">http://git.reviewboard.kde.org/r/104215/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 3737f8c578405f7eb0c0a48bd69febd75420060e by Thomas Lübking to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On March 14th, 2012, 1:12 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Hugo Pereira Da Costa.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 14, 2012, 1:12 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes the absent decoration for GL and new shadows by clearly \
separating visibleRect and decorationRect usage, where decorationRect only handles \
the decoration while visibleRect handles repaints.
This patch is against 4.8 and must likely be handported to 4.9 for the layer repaints \
(alongside shadows and animationeffect ...)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">oxygen (w/ padding) and bespin (w/ new shadows) on xrender and opengl \
backend</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/client.cpp <span style="color: grey">(22aa8dc)</span></li>
<li>kwin/composite.cpp <span style="color: grey">(55a7144)</span></li>
<li>kwin/deleted.cpp <span style="color: grey">(e166bf1)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(49ddd29)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(0541198)</span></li>
<li>kwin/scene_xrender.h <span style="color: grey">(23ff2ad)</span></li>
<li>kwin/scene_xrender.cpp <span style="color: grey">(b2a11c8)</span></li>
<li>kwin/toplevel.cpp <span style="color: grey">(0716c2f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104215/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic