'Re: Review Request: Add offscreen rendering support to xrender backend'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Add offscreen rendering support to xrender backend
From:       "Commit Hook" <null () kde ! org>
Date:       2012-03-20 23:44:45
Message-ID: 20120320234445.13958.58034 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104151/#review11677
-----------------------------------------------------------

This review has been submitted with commit 5cc81e53f88e9a877e252195ca9950b1=
609ab8b2 by Thomas L=C3=BCbking to branch master.

- Commit Hook

On March 13, 2012, 9:07 p.m., Thomas L=C3=BCbking wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104151/
> -----------------------------------------------------------
> =

> (Updated March 13, 2012, 9:07 p.m.)
> =

> =

> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =

> =

> Description
> -------
> =

> Still applies to 4.8 and is ABI stable (i think - no issue with non-recom=
piled 3rd party effects) but technically a new feature...
> =

> Anyway, we'll need such for forthcoming "kwin core animates activation ch=
ange" effects (actually i want crossfading for more occasions) but as a qui=
ck POC, i implemented the screenshot effect as well ;-)
> =

> I'm not sure about the requirement of a stack as in glrendertarget - this=
 would not be an issue to implement.
> -> rationale?
> =

> =

> Diffs
> -----
> =

>   kwin/libkwineffects/kwinxrenderutils.h b094389 =

>   kwin/libkwineffects/kwinxrenderutils.cpp bc58705 =

>   kwin/scene_xrender.cpp b2a11c8 =

> =

> Diff: http://git.reviewboard.kde.org/r/104151/diff/
> =

> =

> Testing
> -------
> =

> Yupp, see screenshot request
> =

> =

> Thanks,
> =

> Thomas L=C3=BCbking
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104151/">http://git.reviewboard.kde.org/r/104151/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 5cc81e53f88e9a877e252195ca9950b1609ab8b2 by Thomas Lübking to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On March 13th, 2012, 9:07 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated March 13, 2012, 9:07 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Still applies to 4.8 and is ABI stable (i think - no issue with \
non-recompiled 3rd party effects) but technically a new feature...

Anyway, we&#39;ll need such for forthcoming &quot;kwin core animates activation \
change&quot; effects (actually i want crossfading for more occasions) but as a quick \
POC, i implemented the screenshot effect as well ;-)

I&#39;m not sure about the requirement of a stack as in glrendertarget - this would \
                not be an issue to implement.
-&gt; rationale?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yupp, see screenshot request</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/libkwineffects/kwinxrenderutils.h <span style="color: \
grey">(b094389)</span></li>

 <li>kwin/libkwineffects/kwinxrenderutils.cpp <span style="color: \
grey">(bc58705)</span></li>

 <li>kwin/scene_xrender.cpp <span style="color: grey">(b2a11c8)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104151/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 