'Review Request: 3 patches to desktop grid'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: 3 patches to desktop grid
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-03-13 0:04:06
Message-ID: 20120313000406.13133.27526 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104247/
-----------------------------------------------------------

Review request for kwin and Martin Gräßlin.

Description
-------

BUG: 254044
activate dragged window if not using present windows in desktop grid
-> behavior is indeed nasty, though only w/o present windows

BUG: 244216
don't exit desktop grid when clicking into absent desktop
-> no opinion on that, "fixed" on the fly

BUG: 252699
swap desktops w/o swapping desktops in between
-> this is actually to review (i mean: view it) - three desktops changing at the same \
time can be distracting, but the result is that you can change non adjacent desktops \
w/o side effects.

This addresses bugs 244216, 252699 and 254044.
    http://bugs.kde.org/show_bug.cgi?id=244216
    http://bugs.kde.org/show_bug.cgi?id=252699
    http://bugs.kde.org/show_bug.cgi?id=254044

Diffs
-----

  kwin/effects/desktopgrid/desktopgrid.h b420389 
  kwin/effects/desktopgrid/desktopgrid.cpp e0beace 

Diff: http://git.reviewboard.kde.org/r/104247/diff/

Testing
-------

yupp, yupp & yupp

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104247/">http://git.reviewboard.kde.org/r/104247/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">BUG: 254044 activate dragged window if not using present windows in \
                desktop grid
-&gt; behavior is indeed nasty, though only w/o present windows

BUG: 244216
don&#39;t exit desktop grid when clicking into absent desktop
-&gt; no opinion on that, &quot;fixed&quot; on the fly

BUG: 252699
swap desktops w/o swapping desktops in between
-&gt; this is actually to review (i mean: view it) - three desktops changing at the \
same time can be distracting, but the result is that you can change non adjacent \
desktops w/o side effects.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yupp, yupp &amp; yupp</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=244216">244216</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=252699">252699</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=254044">254044</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/desktopgrid/desktopgrid.h <span style="color: \
grey">(b420389)</span></li>

 <li>kwin/effects/desktopgrid/desktopgrid.cpp <span style="color: \
grey">(e0beace)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104247/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 