[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Review Request: Sanitize window position on screen change against irregular struts
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-03-11 22:41:37
Message-ID: 20120311224137.23185.34528 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104233/
-----------------------------------------------------------
Review request for kwin and Martin Gräßlin.
Description
-------
That one has cost me nerves.
What happens is that kwin gets locked trapped in it's strut handling because it \
already is in an invalid area, also the wrong clipping area was used. As a solution i \
check
- are we locked?
- are we changing the screen
--> put window into bounds of the new screens workarea
The patch applies to 4.8, so ideally Kai can test & use it, but i'd rather apply it \
to master only - it might cause unforeseen regressions...
This addresses bug 274466.
http://bugs.kde.org/show_bug.cgi?id=274466
Diffs
-----
kwin/geometry.cpp d9ae97a
Diff: http://git.reviewboard.kde.org/r/104233/diff/
Testing
-------
Could reprouce test from bug, now the window moves below the titlebar and from there \
just on.
Thanks,
Thomas Lübking
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104233/">http://git.reviewboard.kde.org/r/104233/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">That one has cost me nerves. What happens is that kwin gets locked \
trapped in it's strut handling because it already is in an invalid area, also the \
wrong clipping area was used. As a solution i check
- are we locked?
- are we changing the screen
--> put window into bounds of the new screens workarea
The patch applies to 4.8, so ideally Kai can test & use it, but i'd rather \
apply it to master only - it might cause unforeseen regressions...</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Could reprouce test from bug, now the window moves below the titlebar \
and from there just on.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=274466">274466</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/geometry.cpp <span style="color: grey">(d9ae97a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104233/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic