'Review Request: split decorationRect & visibleRect usage'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: split decorationRect & visibleRect usage
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-03-10 10:41:29
Message-ID: 20120310104129.4365.753 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104215/
-----------------------------------------------------------

Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Hugo Pereira Da Costa.

Description
-------

This fixes the absent decoration for GL and new shadows by clearly separati=
ng visibleRect and decorationRect usage, where decorationRect only handles =
the decoration while visibleRect handles repaints.

This patch is against 4.8 and must likely be handported to 4.9 for the laye=
r repaints (alongside shadows and animationeffect ...)

Diffs
-----

  kwin/client.cpp 22aa8dc =

  kwin/composite.cpp 55a7144 =

  kwin/deleted.cpp e166bf1 =

  kwin/geometry.cpp d9ae97a =

  kwin/scene.cpp 0541198 =

  kwin/scene_xrender.cpp b2a11c8 =

  kwin/toplevel.cpp 0716c2f =

Diff: http://git.reviewboard.kde.org/r/104215/diff/

Testing
-------

oxygen (w/ padding) and bespin (w/ new shadows) on xrender and opengl backe=
nd

Thanks,

Thomas L=C3=BCbking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104215/">http://git.reviewboard.kde.org/r/104215/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Hugo Pereira Da Costa.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes the absent decoration for GL and new shadows by clearly \
separating visibleRect and decorationRect usage, where decorationRect only handles \
the decoration while visibleRect handles repaints.

This patch is against 4.8 and must likely be handported to 4.9 for the layer repaints \
(alongside shadows and animationeffect ...)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">oxygen (w/ padding) and bespin (w/ new shadows) on xrender and opengl \
backend</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.cpp <span style="color: grey">(22aa8dc)</span></li>

 <li>kwin/composite.cpp <span style="color: grey">(55a7144)</span></li>

 <li>kwin/deleted.cpp <span style="color: grey">(e166bf1)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(d9ae97a)</span></li>

 <li>kwin/scene.cpp <span style="color: grey">(0541198)</span></li>

 <li>kwin/scene_xrender.cpp <span style="color: grey">(b2a11c8)</span></li>

 <li>kwin/toplevel.cpp <span style="color: grey">(0716c2f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104215/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 