'Review Request: invoke glXSwapInterval to actually inform the buffer that we want to align to vblank'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: invoke glXSwapInterval to actually inform the buffer that we want to align to vblank
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-02-28 22:08:11
Message-ID: 20120228220811.9254.59306 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104111/
-----------------------------------------------------------

Review request for kwin and Martin Gräßlin.

Description
-------

Believe it or not, but there's actually a glXSwapInterval function and as far as i \
could figure one should use it since i found contradicting claims about the default \
(some mesa guy in a mailing list entry from 2006 says it's 0, while \
http://www.opengl.org/registry/specs/SGI/swap_control.txt suggests it's one)

However it can't harm -hopefully- and works here on nvidia and GMA/mesa (nvidia has \
SGI & ext, mesa has MESA and OML - d'ooohh) and *might* be the cause of wonky \
swapping because if it's not set the color buffer flushes whenever it feels like what \
can cause waitSync to block for even a random amount of frames or not at all (causing \
tearing) - at least says the guy from 2006 and is supported by the reply of the guy \
who originally asked =D

Diffs
-----

  kwin/libkwineffects/kwinglutils_funcs.h 97a7a6c 
  kwin/libkwineffects/kwinglutils_funcs.cpp 6d79507 
  kwin/scene_opengl_glx.cpp ddebcd0 

Diff: http://git.reviewboard.kde.org/r/104111/diff/

Testing
-------

It's detected and applied, not 100% sure about the resulting impact.

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104111/">http://git.reviewboard.kde.org/r/104111/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Believe it or not, but there&#39;s actually a glXSwapInterval function \
and as far as i could figure one should use it since i found contradicting claims \
about the default (some mesa guy in a mailing list entry from 2006 says it&#39;s 0, \
while http://www.opengl.org/registry/specs/SGI/swap_control.txt suggests it&#39;s \
one)

However it can&#39;t harm -hopefully- and works here on nvidia and GMA/mesa (nvidia \
has SGI &amp; ext, mesa has MESA and OML - d&#39;ooohh) and *might* be the cause of \
wonky swapping because if it&#39;s not set the color buffer flushes whenever it feels \
like what can cause waitSync to block for even a random amount of frames or not at \
all (causing tearing) - at least says the guy from 2006 and is supported by the reply \
of the guy who originally asked =D</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It&#39;s detected and applied, not 100% sure about the resulting \
impact.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/libkwineffects/kwinglutils_funcs.h <span style="color: \
grey">(97a7a6c)</span></li>

 <li>kwin/libkwineffects/kwinglutils_funcs.cpp <span style="color: \
grey">(6d79507)</span></li>

 <li>kwin/scene_opengl_glx.cpp <span style="color: grey">(ddebcd0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104111/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 