[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: hide skip taskbar windows in tabbox
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-02-27 20:13:38
Message-ID: 20120227201338.10407.52403 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 27, 2012, 5:51 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > there is a more specific skip switcher which is already honored. But I'=
m not sure without looking at the code whether it is only for window rules =
or also an xproperty.
> > =
> > What's exactly the usecase for this? We could also use scripts to set t=
he skip switcher state.
> =
> Marco Martin wrote:
> since in active the window strip is used as taskbar shouldn't show an=
y windows hinted to be excluded from taskbar
> =
> Martin Gr=C3=A4=C3=9Flin wrote:
> ok, then I suggest to use a script which sets the skip switcher state=
for all skip taksbar windows.
> =
> I prefer to have the device adjustments as scripts instead of code an=
d there are users who would like to have that on desktop, too :-)
see review request 104099 for the script :-)
My suggestion would be to ship the script and enable it by default on PA in=
stead of shipping this review. Other opinions?
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104094/#review10956
-----------------------------------------------------------
On Feb. 27, 2012, 4:54 p.m., Marco Martin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104094/
> -----------------------------------------------------------
> =
> (Updated Feb. 27, 2012, 4:54 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> this is for the qml windowstrip, hides the windows that aren't wanted i t=
he taskbar.
> =
> however i understand the use case to have hidden windows shown in a norma=
l tabbox.
> perhaps honoring the skiptaskbar parameter should be something that can b=
e set from qml so the windowstrip could behave differently from the regular=
tabbox here?
> =
> =
> Diffs
> -----
> =
> kwin/tabbox/tabbox.cpp 3f26397 =
> =
> Diff: http://git.reviewboard.kde.org/r/104094/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Marco Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104094/">http://git.reviewboard.kde.org/r/104094/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 27th, 2012, 5:51 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">there is a more specific skip switcher which is already honored. But \
I'm not sure without looking at the code whether it is only for window rules or also an xproperty.
What's exactly the usecase for this? We could also use scripts to set the skip switcher state.</pre>
</blockquote>
<p>On February 27th, 2012, 6:01 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">since in active the window strip is used as taskbar shouldn't \
show any windows hinted to be excluded from taskbar</pre> </blockquote>
<p>On February 27th, 2012, 6:14 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">ok, then I suggest to use a script which sets the skip switcher \
state for all skip taksbar windows.
I prefer to have the device adjustments as scripts instead of code and there are users who would like to \
have that on desktop, too :-)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">see review request 104099 for the script :-)
My suggestion would be to ship the script and enable it by default on PA instead of shipping this review. \
Other opinions?</pre> <br />
<p>- Martin</p>
<br />
<p>On February 27th, 2012, 4:54 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2012, 4:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is for the qml windowstrip, hides the \
windows that aren't wanted i the taskbar.
however i understand the use case to have hidden windows shown in a normal tabbox.
perhaps honoring the skiptaskbar parameter should be something that can be set from qml so the \
windowstrip could behave differently from the regular tabbox here?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/tabbox/tabbox.cpp <span style="color: grey">(3f26397)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104094/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic