--===============7397558762578567249== Content-Type: multipart/alternative; boundary="===============0672248284633628553==" --===============0672248284633628553== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Feb. 27, 2012, 5:51 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > > there is a more specific skip switcher which is already honored. But I'= m not sure without looking at the code whether it is only for window rules = or also an xproperty. > > = > > What's exactly the usecase for this? We could also use scripts to set t= he skip switcher state. > = > Marco Martin wrote: > since in active the window strip is used as taskbar shouldn't show an= y windows hinted to be excluded from taskbar > = > Martin Gr=C3=A4=C3=9Flin wrote: > ok, then I suggest to use a script which sets the skip switcher state= for all skip taksbar windows. > = > I prefer to have the device adjustments as scripts instead of code an= d there are users who would like to have that on desktop, too :-) see review request 104099 for the script :-) My suggestion would be to ship the script and enable it by default on PA in= stead of shipping this review. Other opinions? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104094/#review10956 ----------------------------------------------------------- On Feb. 27, 2012, 4:54 p.m., Marco Martin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104094/ > ----------------------------------------------------------- > = > (Updated Feb. 27, 2012, 4:54 p.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > this is for the qml windowstrip, hides the windows that aren't wanted i t= he taskbar. > = > however i understand the use case to have hidden windows shown in a norma= l tabbox. > perhaps honoring the skiptaskbar parameter should be something that can b= e set from qml so the windowstrip could behave differently from the regular= tabbox here? > = > = > Diffs > ----- > = > kwin/tabbox/tabbox.cpp 3f26397 = > = > Diff: http://git.reviewboard.kde.org/r/104094/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Marco Martin > = > --===============0672248284633628553== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104094/

On February 27th, 2012, 5:51 p.m., Martin G= r=C3=A4=C3=9Flin wrote:

there is =
a more specific skip switcher which is already honored. But I'm not sur=
e without looking at the code whether it is only for window rules or also a=
n xproperty.

What's exactly the usecase for this? We could also use scripts to set t=
he skip switcher state.

On February 27th, 2012, 6:01 p.m., Marco Martin wrote:

since in =
active the window strip is used as taskbar shouldn't show any windows h=
inted to be excluded from taskbar

On February 27th, 2012, 6:14 p.m., Martin Gr=C3=A4=C3=9Flin wrot= e:

ok, then =
I suggest to use a script which sets the skip switcher state for all skip t=
aksbar windows.

I prefer to have the device adjustments as scripts instead of code and ther=
e are users who would like to have that on desktop, too :-)

see review =
request 104099 for the script :-)

My suggestion would be to ship the script and enable it by default on PA in=
stead of shipping this review. Other opinions?

- Martin

On February 27th, 2012, 4:54 p.m., Marco Martin wrote:

Review request for kwin.

By Marco Martin.

Updated Feb. 27, 2012, 4:54 p.m.

Descripti= on

this is for the qml windowstrip, hides the windows that aren=
't wanted i the taskbar.

however i understand the use case to have hidden windows shown in a normal =
tabbox.
perhaps honoring the skiptaskbar parameter should be something that can be =
set from qml so the windowstrip could behave differently from the regular t=
abbox here?

Diffs=

kwin/tabbox/tabbox.cpp (3f26397)

--===============0672248284633628553==-- --===============7397558762578567249== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============7397558762578567249==--