[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Fix close window decoration on double click on menu button
From: "Commit Hook" <null () kde ! org>
Date: 2012-02-27 18:27:58
Message-ID: 20120227182758.1195.32835 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103995/#review10961
-----------------------------------------------------------
This review has been submitted with commit 27b667f49562963ea3f13d5b9dd56ff846feb75a by Martin \
Gräßlin to branch master.
- Commit Hook
On Feb. 26, 2012, 6:39 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103995/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2012, 6:39 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Currently decorations based on KCommonDecoration require three mouse clicks on the menu \
> button to close it. The reason is: 1. mouse click: opens menu
> 2. mouse click: hides menu
> 3. mouse click: double click which reaches the decoration
>
> This patch incorporates some ideas from fixing the same issue in Aurorae 3 today: using a \
> timer on mouse press with doubleClickInterval and show the menu only after the interval \
> passed. This slightly delays the appearance of the menu, because of that right click behaves \
> in the normal way to open the menu.
> Given that this used to be broken for years and introduces a slight change in behavior I am \
> not sure whether this is also 4.8 material.
>
> This addresses bug 157184.
> http://bugs.kde.org/show_bug.cgi?id=157184
>
>
> Diffs
> -----
>
> kwin/libkdecorations/kcommondecoration.h d207da8
> kwin/libkdecorations/kcommondecoration.cpp 480a437
>
> Diff: http://git.reviewboard.kde.org/r/103995/diff/
>
>
> Testing
> -------
>
> clicked a lot on the menu button in Oxygen and everything seems fine.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103995/">http://git.reviewboard.kde.org/r/103995/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit \
27b667f49562963ea3f13d5b9dd56ff846feb75a by Martin Gräßlin to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On February 26th, 2012, 6:39 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2012, 6:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently decorations \
based on KCommonDecoration require three mouse clicks on the menu button to close it. The \
reason is: 1. mouse click: opens menu
2. mouse click: hides menu
3. mouse click: double click which reaches the decoration
This patch incorporates some ideas from fixing the same issue in Aurorae 3 today: using a timer \
on mouse press with doubleClickInterval and show the menu only after the interval passed. This \
slightly delays the appearance of the menu, because of that right click behaves in the normal \
way to open the menu.
Given that this used to be broken for years and introduces a slight change in behavior I am not \
sure whether this is also 4.8 material.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">clicked a lot on the \
menu button in Oxygen and everything seems fine.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=157184">157184</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/libkdecorations/kcommondecoration.h <span style="color: grey">(d207da8)</span></li>
<li>kwin/libkdecorations/kcommondecoration.cpp <span style="color: grey">(480a437)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103995/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic