From kwin Mon Feb 27 18:27:58 2012 From: "Commit Hook" Date: Mon, 27 Feb 2012 18:27:58 +0000 To: kwin Subject: Re: Review Request: Fix close window decoration on double click on menu button Message-Id: <20120227182758.1195.32835 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=133036732208173 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4156895502972874582==" --===============4156895502972874582== Content-Type: multipart/alternative; boundary="===============4008594035156121742==" --===============4008594035156121742== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103995/#review10961 ----------------------------------------------------------- This review has been submitted with commit 27b667f49562963ea3f13d5b9dd56ff8= 46feb75a by Martin Gr=C3=A4=C3=9Flin to branch master. - Commit Hook On Feb. 26, 2012, 6:39 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103995/ > ----------------------------------------------------------- > = > (Updated Feb. 26, 2012, 6:39 p.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > Currently decorations based on KCommonDecoration require three mouse clic= ks on the menu button to close it. The reason is: > 1. mouse click: opens menu > 2. mouse click: hides menu > 3. mouse click: double click which reaches the decoration > = > This patch incorporates some ideas from fixing the same issue in Aurorae = 3 today: using a timer on mouse press with doubleClickInterval and show the= menu only after the interval passed. This slightly delays the appearance o= f the menu, because of that right click behaves in the normal way to open t= he menu. > = > Given that this used to be broken for years and introduces a slight chang= e in behavior I am not sure whether this is also 4.8 material. > = > = > This addresses bug 157184. > http://bugs.kde.org/show_bug.cgi?id=3D157184 > = > = > Diffs > ----- > = > kwin/libkdecorations/kcommondecoration.h d207da8 = > kwin/libkdecorations/kcommondecoration.cpp 480a437 = > = > Diff: http://git.reviewboard.kde.org/r/103995/diff/ > = > = > Testing > ------- > = > clicked a lot on the menu button in Oxygen and everything seems fine. > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============4008594035156121742== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103995/ 

This revie=
w has been submitted with commit 27b667f49562963ea3f13d5b9dd56ff846feb75a b=
y Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit


On February 26th, 2012, 6:39 p.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.
By Martin Gr=C3=A4=C3=9Flin.

Updated Feb. 26, 2012, 6:39 p.m.

Descripti= on 

Currently decorations based on KCommonDecoration require thr=
ee mouse clicks on the menu button to close it. The reason is:
1. mouse click: opens menu
2. mouse click: hides menu
3. mouse click: double click which reaches the decoration

This patch incorporates some ideas from fixing the same issue in Aurorae 3 =
today: using a timer on mouse press with doubleClickInterval and show the m=
enu only after the interval passed. This slightly delays the appearance of =
the menu, because of that right click behaves in the normal way to open the=
 menu.

Given that this used to be broken for years and introduces a slight change =
in behavior I am not sure whether this is also 4.8 material.

Testing <= /h1> 
clicked a lot on the menu button in Oxygen and everything se=
ems fine.
Bugs: 157184

Diffs=

  • kwin/libkdecorations/kcommondecoration.h (= d207da8)
  • kwin/libkdecorations/kcommondecoration.cpp (480a437)

View Diff
--===============4008594035156121742==-- --===============4156895502972874582== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============4156895502972874582==--