[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Videowall script
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-02-18 14:48:14
Message-ID: 20120218144814.32739.74890 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104014/#review10719
-----------------------------------------------------------
kwin/scripts/videowall/contents/code/main.js
<http://git.reviewboard.kde.org/r/104014/#comment8721>
if (client.resourceName == xv) { //mplayer
return true;
}
if (client.resourceName == ffplay) {
return true;
}
should iirc also hit some mediacenter stuff
kwin/scripts/videowall/contents/code/main.js
<http://git.reviewboard.kde.org/r/104014/#comment8722>
concerning readability - i had to look twice to understand that this doesn't lack \
a closing parenthesis but is an inline function definition ;-P
- Thomas Lübking
On Feb. 18, 2012, 11:46 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104014/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2012, 11:46 a.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> General: I changed KWin scripts to use Plasma Packages and install services. This \
> allows us to ship scripts pre-installed but not enabled. This is a first such \
> script.
> This script allows to have video fullscreen windows span all attached screens \
> creating a video wall.
> This replaces the removed functionality that you could disable xinerama support \
> inside KWin for fullscreen windows.
> Currently vlc, smplayer and dragon player are recognized as video players.
>
>
> Diffs
> -----
>
> kwin/CMakeLists.txt 74e9879
> kwin/scripts/CMakeLists.txt PRE-CREATION
> kwin/scripts/videowall/contents/code/main.js PRE-CREATION
> kwin/scripts/videowall/metadata.desktop PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/104014/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104014/">http://git.reviewboard.kde.org/r/104014/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104014/diff/1/?file=50390#file50390line10" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/scripts/videowall/contents/code/main.js</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">function isVideoPlayer(client) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">10</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if \
(client.resourceName == xv) { //mplayer return true;
}
if (client.resourceName == ffplay) {
return true;
}
should iirc also hit some mediacenter stuff</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104014/diff/1/?file=50390#file50390line14" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/scripts/videowall/contents/code/main.js</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">function isVideoPlayer(client) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">14</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nx">workspace</span><span class="p">.</span><span \
class="nx">clientFullScreenSet</span><span class="p">.</span><span \
class="nx">connect</span><span class="p">(</span><span \
class="kd">function</span><span class="p">(</span><span class="nx">client</span><span \
class="p">,</span> <span class="nx">set</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">concerning \
readability - i had to look twice to understand that this doesn't lack a closing \
parenthesis but is an inline function definition ;-P</pre> </div>
<br />
<p>- Thomas</p>
<br />
<p>On February 18th, 2012, 11:46 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2012, 11:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">General: I changed KWin scripts to use Plasma Packages and install \
services. This allows us to ship scripts pre-installed but not enabled. This is a \
first such script.
This script allows to have video fullscreen windows span all attached screens \
creating a video wall.
This replaces the removed functionality that you could disable xinerama support \
inside KWin for fullscreen windows.
Currently vlc, smplayer and dragon player are recognized as video players.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/CMakeLists.txt <span style="color: grey">(74e9879)</span></li>
<li>kwin/scripts/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/scripts/videowall/contents/code/main.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/scripts/videowall/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104014/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic