From kwin Sat Feb 18 14:48:14 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Sat, 18 Feb 2012 14:48:14 +0000 To: kwin Subject: Re: Review Request: Videowall script Message-Id: <20120218144814.32739.74890 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=132957651716820 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2726943771592942020==" --===============2726943771592942020== Content-Type: multipart/alternative; boundary="===============9141295472257291137==" --===============9141295472257291137== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104014/#review10719 ----------------------------------------------------------- kwin/scripts/videowall/contents/code/main.js if (client.resourceName =3D=3D xv) { //mplayer return true; } = if (client.resourceName =3D=3D ffplay) { return true; } = should iirc also hit some mediacenter stuff kwin/scripts/videowall/contents/code/main.js concerning readability - i had to look twice to understand that this do= esn't lack a closing parenthesis but is an inline function definition ;-P - Thomas L=C3=BCbking On Feb. 18, 2012, 11:46 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104014/ > ----------------------------------------------------------- > = > (Updated Feb. 18, 2012, 11:46 a.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > General: I changed KWin scripts to use Plasma Packages and install servic= es. This allows us to ship scripts pre-installed but not enabled. This is a= first such script. > = > This script allows to have video fullscreen windows span all attached scr= eens creating a video wall. > = > This replaces the removed functionality that you could disable xinerama s= upport inside KWin for fullscreen windows. > = > Currently vlc, smplayer and dragon player are recognized as video players. > = > = > Diffs > ----- > = > kwin/CMakeLists.txt 74e9879 = > kwin/scripts/CMakeLists.txt PRE-CREATION = > kwin/scripts/videowall/contents/code/main.js PRE-CREATION = > kwin/scripts/videowall/metadata.desktop PRE-CREATION = > = > Diff: http://git.reviewboard.kde.org/r/104014/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============9141295472257291137== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104014/

= =

kwin/scripts/videowall/contents/code/main.js (Diff revision 1)
	function isVideoPlayer(client) {
		10	}

if (client.resourceName =3D=3D xv) { //mplayer
   return true;
}

if (client.resourceName =3D=3D ffplay) {
   return true;
}

should iirc also hit some mediacenter stuff

= =

kwin/scripts/videowall/contents/code/main.js (Diff revision 1)
	function isVideoPlayer(client) {
		14	workspace.clientFullScreenSet.connect(function(c= lient, set) {

concerning readability - i had to look twice to understand that this=
 doesn't lack a closing parenthesis but is an inline function definitio=
n ;-P

- Thomas

On February 18th, 2012, 11:46 a.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.

By Martin Gr=C3=A4=C3=9Flin.

Updated Feb. 18, 2012, 11:46 a.m.

Descripti= on

General: I changed KWin scripts to use Plasma Packages and i=
nstall services. This allows us to ship scripts pre-installed but not enabl=
ed. This is a first such script.

This script allows to have video fullscreen windows span all attached scree=
ns creating a video wall.
    =

This replaces the removed functionality that you could disable xinerama sup=
port inside KWin for fullscreen windows.

Currently vlc, smplayer and dragon player are recognized as video players.

Diffs=

kwin/CMakeLists.txt (74e9879)
kwin/scripts/CMakeLists.txt (PRE-CREATION)=
kwin/scripts/videowall/contents/code/main.js (PRE-CREATION)
kwin/scripts/videowall/metadata.desktop (P= RE-CREATION)

--===============9141295472257291137==-- --===============2726943771592942020== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============2726943771592942020==--