'Re: Review Request: Drop Xinerama related options in KWin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Drop Xinerama related options in KWin
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-01-26 6:47:02
Message-ID: 20120126064702.8854.12065 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103756/
-----------------------------------------------------------

(Updated Jan. 26, 2012, 6:47 a.m.)

Review request for kwin and Plasma.

Changes
-------

* dropped one more option
* simplified the clientArea() method by merging the parts returning the sam=
e values.

Description
-------

As discussed on the mailinglist: drop of the xinerama related options and t=
he kcm. Given that the show unmanaged windows on option is in fact not used=
, I dropped the complete KCM.

Diffs (updated)
-----

  kcontrol/CMakeLists.txt 8cd9a46 =

  kcontrol/xinerama/CMakeLists.txt fe332e5 =

  kcontrol/xinerama/Messages.sh f4aa134 =

  kcontrol/xinerama/interface_util.h 8a4fcd1 =

  kcontrol/xinerama/kcmxinerama.h 18b9241 =

  kcontrol/xinerama/kcmxinerama.cpp a456b2c =

  kcontrol/xinerama/test_kcm_xinerama.cpp a358a2c =

  kcontrol/xinerama/xinerama.desktop e8ce525 =

  kcontrol/xinerama/xineramawidget.h 2c446a2 =

  kcontrol/xinerama/xineramawidget.cpp df9cb2f =

  kcontrol/xinerama/xineramawidget.ui 90ec4d4 =

  kwin/geometry.cpp a414e26 =

  kwin/manage.cpp c551eac =

  kwin/options.h 9dc29cf =

  kwin/options.cpp d496569 =

  kwin/tabbox/tabbox.cpp 3051316 =

  kwin/toplevel.cpp ffe7f0c =

  kwin/workspace.cpp 69b4ecb =

Diff: http://git.reviewboard.kde.org/r/103756/diff/diff

Testing
-------

Fullscreen: works
Maximize: works
Movment: works
Placement: works

Thanks,

Martin Gr=C3=A4=C3=9Flin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103756/">http://git.reviewboard.kde.org/r/103756/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Jan. 26, 2012, 6:47 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* dropped one more option
* simplified the clientArea() method by merging the parts returning the same \
values.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As discussed on the mailinglist: drop of the xinerama related options \
and the kcm. Given that the show unmanaged windows on option is in fact not used, I \
dropped the complete KCM.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">Fullscreen: works
Maximize: works
Movment: works
Placement: works</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kcontrol/CMakeLists.txt <span style="color: grey">(8cd9a46)</span></li>

 <li>kcontrol/xinerama/CMakeLists.txt <span style="color: grey">(fe332e5)</span></li>

 <li>kcontrol/xinerama/Messages.sh <span style="color: grey">(f4aa134)</span></li>

 <li>kcontrol/xinerama/interface_util.h <span style="color: \
grey">(8a4fcd1)</span></li>

 <li>kcontrol/xinerama/kcmxinerama.h <span style="color: grey">(18b9241)</span></li>

 <li>kcontrol/xinerama/kcmxinerama.cpp <span style="color: \
grey">(a456b2c)</span></li>

 <li>kcontrol/xinerama/test_kcm_xinerama.cpp <span style="color: \
grey">(a358a2c)</span></li>

 <li>kcontrol/xinerama/xinerama.desktop <span style="color: \
grey">(e8ce525)</span></li>

 <li>kcontrol/xinerama/xineramawidget.h <span style="color: \
grey">(2c446a2)</span></li>

 <li>kcontrol/xinerama/xineramawidget.cpp <span style="color: \
grey">(df9cb2f)</span></li>

 <li>kcontrol/xinerama/xineramawidget.ui <span style="color: \
grey">(90ec4d4)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(a414e26)</span></li>

 <li>kwin/manage.cpp <span style="color: grey">(c551eac)</span></li>

 <li>kwin/options.h <span style="color: grey">(9dc29cf)</span></li>

 <li>kwin/options.cpp <span style="color: grey">(d496569)</span></li>

 <li>kwin/tabbox/tabbox.cpp <span style="color: grey">(3051316)</span></li>

 <li>kwin/toplevel.cpp <span style="color: grey">(ffe7f0c)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(69b4ecb)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103756/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 