From kwin Thu Jan 26 06:47:02 2012 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Thu, 26 Jan 2012 06:47:02 +0000 To: kwin Subject: Re: Review Request: Drop Xinerama related options in KWin Message-Id: <20120126064702.8854.12065 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=132756061416987 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2010251289805896597==" --===============2010251289805896597== Content-Type: multipart/alternative; boundary="===============5681855854585679525==" --===============5681855854585679525== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103756/ ----------------------------------------------------------- (Updated Jan. 26, 2012, 6:47 a.m.) Review request for kwin and Plasma. Changes ------- * dropped one more option * simplified the clientArea() method by merging the parts returning the sam= e values. Description ------- As discussed on the mailinglist: drop of the xinerama related options and t= he kcm. Given that the show unmanaged windows on option is in fact not used= , I dropped the complete KCM. Diffs (updated) ----- kcontrol/CMakeLists.txt 8cd9a46 = kcontrol/xinerama/CMakeLists.txt fe332e5 = kcontrol/xinerama/Messages.sh f4aa134 = kcontrol/xinerama/interface_util.h 8a4fcd1 = kcontrol/xinerama/kcmxinerama.h 18b9241 = kcontrol/xinerama/kcmxinerama.cpp a456b2c = kcontrol/xinerama/test_kcm_xinerama.cpp a358a2c = kcontrol/xinerama/xinerama.desktop e8ce525 = kcontrol/xinerama/xineramawidget.h 2c446a2 = kcontrol/xinerama/xineramawidget.cpp df9cb2f = kcontrol/xinerama/xineramawidget.ui 90ec4d4 = kwin/geometry.cpp a414e26 = kwin/manage.cpp c551eac = kwin/options.h 9dc29cf = kwin/options.cpp d496569 = kwin/tabbox/tabbox.cpp 3051316 = kwin/toplevel.cpp ffe7f0c = kwin/workspace.cpp 69b4ecb = Diff: http://git.reviewboard.kde.org/r/103756/diff/diff Testing ------- Fullscreen: works Maximize: works Movment: works Placement: works Thanks, Martin Gr=C3=A4=C3=9Flin --===============5681855854585679525== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103756/

Review request for kwin and Plasma.
By Martin Gr=C3=A4=C3=9Flin.

Updated Jan. 26, 2012, 6:47 a.m.

Changes 
* dropped one more option
* simplified the clientArea() method by merging the parts returning the sam=
e values.

Descripti= on 

As discussed on the mailinglist: drop of the xinerama relate=
d options and the kcm. Given that the show unmanaged windows on option is i=
n fact not used, I dropped the complete KCM.

Testing <= /h1> 
Fullscreen: works
Maximize: works
Movment: works
Placement: works

Diffs= (updated)

  • kcontrol/CMakeLists.txt (8cd9a46)
  • kcontrol/xinerama/CMakeLists.txt (fe332e5)=
  • kcontrol/xinerama/Messages.sh (f4aa134)
  • kcontrol/xinerama/interface_util.h (8a4fcd= 1)
  • kcontrol/xinerama/kcmxinerama.h (18b9241)<= /span>
  • kcontrol/xinerama/kcmxinerama.cpp (a456b2c= )
  • kcontrol/xinerama/test_kcm_xinerama.cpp (a= 358a2c)
  • kcontrol/xinerama/xinerama.desktop (e8ce52= 5)
  • kcontrol/xinerama/xineramawidget.h (2c446a= 2)
  • kcontrol/xinerama/xineramawidget.cpp (df9c= b2f)
  • kcontrol/xinerama/xineramawidget.ui (90ec4= d4)
  • kwin/geometry.cpp (a414e26)
  • kwin/manage.cpp (c551eac)
  • kwin/options.h (9dc29cf)
  • kwin/options.cpp (d496569)
  • kwin/tabbox/tabbox.cpp (3051316)
  • kwin/toplevel.cpp (ffe7f0c)
  • kwin/workspace.cpp (69b4ecb)

View Diff
--===============5681855854585679525==-- --===============2010251289805896597== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============2010251289805896597==--