[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: fixing high cpu usage bugs
From: "Philipp Knechtges" <philipp-dev () knechtges ! com>
Date: 2012-01-19 12:38:18
Message-ID: 20120119123818.4964.23865 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103733/
-----------------------------------------------------------
(Updated Jan. 19, 2012, 12:38 p.m.)
Review request for kwin, Thomas Lübking, Martin Gräßlin, and Fredrik Höglund.
Changes
-------
Using Martin's solution which utilizes a singleshot timer to delete the window.
Description
-------
In some unfortunate situations it is possible that a window is deleted
before it is marked ready_for_painting=true. The last point is
especially troublesome for effects that reference the deleted window.
This addresses bugs 288948 and 290025.
http://bugs.kde.org/show_bug.cgi?id=288948
http://bugs.kde.org/show_bug.cgi?id=290025
Diffs (updated)
-----
kwin/deleted.h 1f98aaf
kwin/deleted.cpp f465159
Diff: http://git.reviewboard.kde.org/r/103733/diff/diff
Testing
-------
Fixes the high cpu usage bug, which I can reliably trigger with glide effect enabled and starting amarok.
This should definitely go into the 4.8 release.
Thanks,
Philipp Knechtges
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103733/">http://git.reviewboard.kde.org/r/103733/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Thomas Lübking, Martin Gräßlin, and Fredrik \
Höglund.</div> <div>By Philipp Knechtges.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2012, 12:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using Martin's solution which utilizes a singleshot timer to delete \
the window.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In some unfortunate situations it is possible that a window is deleted \
before it is marked ready_for_painting=true. The last point is especially troublesome \
for effects that reference the deleted window.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes the high cpu usage bug, which I can reliably trigger with glide \
effect enabled and starting amarok. This should definitely go into the 4.8 \
release.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=288948">288948</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=290025">290025</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/deleted.h <span style="color: grey">(1f98aaf)</span></li>
<li>kwin/deleted.cpp <span style="color: grey">(f465159)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103733/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic