[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: fixing high cpu usage bugs
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-01-19 10:53:04
Message-ID: 20120119105304.29924.19128 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103733/#review9942
-----------------------------------------------------------
kwin/composite.cpp
<http://git.reviewboard.kde.org/r/103733/#comment8215>
wouldn't it make more sense to set readyForPainting to true in copyToDeleted? Or \
just discard the deleted in case readyForPainting is false?
- Martin Gräßlin
On Jan. 19, 2012, 10:48 a.m., Philipp Knechtges wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103733/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2012, 10:48 a.m.)
>
>
> Review request for kwin, Thomas Lübking, Martin Gräßlin, and Fredrik Höglund.
>
>
> Description
> -------
>
> In some unfortunate situations it is possible that a window is deleted
> before it is marked ready_for_painting=true. The last point is
> especially troublesome for effects that reference the deleted window.
>
>
> This addresses bugs 288948 and 290025.
> http://bugs.kde.org/show_bug.cgi?id=288948
> http://bugs.kde.org/show_bug.cgi?id=290025
>
>
> Diffs
> -----
>
> kwin/composite.cpp 55a714400716b4967218c794c0e336ff9d10d5e3
>
> Diff: http://git.reviewboard.kde.org/r/103733/diff/diff
>
>
> Testing
> -------
>
> Fixes the high cpu usage bug, which I can reliably trigger with glide effect \
> enabled and starting amarok. This should definitely go into the 4.8 release.
>
>
> Thanks,
>
> Philipp Knechtges
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103733/">http://git.reviewboard.kde.org/r/103733/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103733/diff/1/?file=47472#file47472line414" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/composite.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Workspace::performCompositing()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">414</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">Deleted</span><span \
class="o">*</span> <span class="n">del</span> <span class="o">=</span> <span \
class="k">dynamic_cast</span><span class="o"><</span><span \
class="n">Deleted</span><span class="o">*></span><span class="p">(</span><span \
class="n">t</span><span class="p">))</span> <span class="p">{</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">415</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">del</span><span class="o">-></span><span \
class="n">discard</span><span class="p">(</span><span class="n">Allowed</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">416</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">wouldn't it make more sense to set readyForPainting to true in \
copyToDeleted? Or just discard the deleted in case readyForPainting is false?</pre> \
</div> <br />
<p>- Martin</p>
<br />
<p>On January 19th, 2012, 10:48 a.m., Philipp Knechtges wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Thomas Lübking, Martin Gräßlin, and Fredrik \
Höglund.</div> <div>By Philipp Knechtges.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2012, 10:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In some unfortunate situations it is possible that a window is deleted \
before it is marked ready_for_painting=true. The last point is especially troublesome \
for effects that reference the deleted window.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes the high cpu usage bug, which I can reliably trigger with glide \
effect enabled and starting amarok. This should definitely go into the 4.8 \
release.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=288948">288948</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=290025">290025</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: \
grey">(55a714400716b4967218c794c0e336ff9d10d5e3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103733/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic