'Re: Review Request: Fix regression igonring hiddenPreviews on stacking updates'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Fix regression igonring hiddenPreviews on stacking updates
From:       "Commit Hook" <null () kde ! org>
Date:       2012-01-13 15:43:22
Message-ID: 20120113154322.6683.96652 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103687/#review9800
-----------------------------------------------------------

This review has been submitted with commit c5c08d45e90e88ab36d49b20ba7f1cccba4a7019 \
by Thomas Lübking to branch master.

- Commit Hook

On Jan. 13, 2012, 2:07 a.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103687/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2012, 2:07 a.m.)
> 
> 
> Review request for kwin and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> You were ultimately right =)
> 
> commit a55125b9dc1bd60e258dec133878c3da4178063d accidentally removed stacking
> handling of hiddenPreview windows alongside the dropped topmenu support,
> resulting in them being unhandled by xrestack, turning them on top.
> 
> As a result only the input shaping prevents them from intercepting events and
> this is probably not supported by DnD
> 
> ---- Sidenote:
> Since the array was replaced by a QVector, we should estimate the required \
> dimension (little more problematic because of the input windows, possibly \
> 2*stacking_order count + 8 edges + the support client) for performance reasons. We \
> however got some time left and this is rather minor. 
> 
> This addresses bug 289945.
> http://bugs.kde.org/show_bug.cgi?id=289945
> 
> 
> Diffs
> -----
> 
> kwin/layers.cpp 931b988 
> 
> Diff: http://git.reviewboard.kde.org/r/103687/diff/diff
> 
> 
> Testing
> -------
> 
> Yes, mentioned amarok ./. dolphin ./. notifications reliably used to trigger it for \
> me - over and over again. Stopped immediately after applying this patch. 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103687/">http://git.reviewboard.kde.org/r/103687/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit c5c08d45e90e88ab36d49b20ba7f1cccba4a7019 by Thomas Lübking to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On January 13th, 2012, 2:07 a.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Jan. 13, 2012, 2:07 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">You were ultimately right =)

commit a55125b9dc1bd60e258dec133878c3da4178063d accidentally removed stacking
handling of hiddenPreview windows alongside the dropped topmenu support,
resulting in them being unhandled by xrestack, turning them on top.

As a result only the input shaping prevents them from intercepting events and
this is probably not supported by DnD

---- Sidenote:
Since the array was replaced by a QVector, we should estimate the required dimension \
(little more problematic because of the input windows, possibly 2*stacking_order \
count + 8 edges + the support client) for performance reasons. We however got some \
time left and this is rather minor.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, mentioned amarok ./. dolphin ./. notifications reliably used to \
trigger it for me - over and over again. Stopped immediately after applying this \
patch.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=289945">289945</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/layers.cpp <span style="color: grey">(931b988)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103687/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 