--===============4152131370692551315== Content-Type: multipart/alternative; boundary="===============5746370912315237956==" --===============5746370912315237956== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103687/#review9800 ----------------------------------------------------------- This review has been submitted with commit c5c08d45e90e88ab36d49b20ba7f1ccc= ba4a7019 by Thomas L=C3=BCbking to branch master. - Commit Hook On Jan. 13, 2012, 2:07 a.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103687/ > ----------------------------------------------------------- > = > (Updated Jan. 13, 2012, 2:07 a.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > You were ultimately right =3D) > = > commit a55125b9dc1bd60e258dec133878c3da4178063d accidentally removed stac= king > handling of hiddenPreview windows alongside the dropped topmenu support, > resulting in them being unhandled by xrestack, turning them on top. > = > As a result only the input shaping prevents them from intercepting events= and > this is probably not supported by DnD > = > ---- Sidenote: > Since the array was replaced by a QVector, we should estimate the require= d dimension (little more problematic because of the input windows, possibly= 2*stacking_order count + 8 edges + the support client) for performance rea= sons. We however got some time left and this is rather minor. > = > = > This addresses bug 289945. > http://bugs.kde.org/show_bug.cgi?id=3D289945 > = > = > Diffs > ----- > = > kwin/layers.cpp 931b988 = > = > Diff: http://git.reviewboard.kde.org/r/103687/diff/diff > = > = > Testing > ------- > = > Yes, mentioned amarok ./. dolphin ./. notifications reliably used to trig= ger it for me - over and over again. Stopped immediately after applying thi= s patch. > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============5746370912315237956== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103687/

This revie=
w has been submitted with commit c5c08d45e90e88ab36d49b20ba7f1cccba4a7019 b=
y Thomas L=C3=BCbking to branch master.

- Commit

On January 13th, 2012, 2:07 a.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

By Thomas L=C3=BCbking.

Updated Jan. 13, 2012, 2:07 a.m.

Descripti= on

You were ultimately right =3D)

commit a55125b9dc1bd60e258dec133878c3da4178063d accidentally removed stacki=
ng
handling of hiddenPreview windows alongside the dropped topmenu support,
resulting in them being unhandled by xrestack, turning them on top.

As a result only the input shaping prevents them from intercepting events a=
nd
this is probably not supported by DnD

---- Sidenote:
Since the array was replaced by a QVector, we should estimate the required =
dimension (little more problematic because of the input windows, possibly 2=
*stacking_order count + 8 edges + the support client) for performance reaso=
ns. We however got some time left and this is rather minor.

Testing <= /h1>

Yes, mentioned amarok ./. dolphin ./. notifications reliably=
 used to trigger it for me - over and over again. Stopped immediately after=
 applying this patch.

Bugs: 289945

Diffs=

kwin/layers.cpp (931b988)

--===============5746370912315237956==-- --===============4152131370692551315== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============4152131370692551315==--