[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Add dbus interface "activeEffects" [debugging
From: "Commit Hook" <null () kde ! org>
Date: 2012-01-02 18:22:58
Message-ID: 20120102182258.27188.24877 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103572/#review9467
-----------------------------------------------------------
This review has been submitted with commit 4d2f807179424424ac25df56b420622946fe505e \
by Thomas Lübking to branch KDE/4.8.
- Commit Hook
On Dec. 29, 2011, 10:48 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103572/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2011, 10:48 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> Immediately spotted ResizeEffect::isActive() wasn't implemented and did that as \
> well. I recommend having this in 4.8 and best before a pot. second rc.
> Function is tiny and does nothing unless we tell the user to call that, but might \
> help on debugging and i myself wanted to check whether my code caught the exit more \
> than once as well.
>
> This addresses bugs (CC), 288948 and 290025.
> http://bugs.kde.org/show_bug.cgi?id=(CC)
> http://bugs.kde.org/show_bug.cgi?id=288948
> http://bugs.kde.org/show_bug.cgi?id=290025
>
>
> Diffs
> -----
>
> kwin/composite.cpp 8c793ea
> kwin/effects.h 6530871
> kwin/effects.cpp e388b33
> kwin/effects/resize/resize.h 88d29db
> kwin/org.kde.KWin.xml bd993ed
> kwin/workspace.h 6069324
>
> Diff: http://git.reviewboard.kde.org/r/103572/diff/diff
>
>
> Testing
> -------
>
> Yes, prints "kwin4_effect_beclock" ;-)
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103572/">http://git.reviewboard.kde.org/r/103572/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 4d2f807179424424ac25df56b420622946fe505e by Thomas Lübking to \
branch KDE/4.8.</pre> <br />
<p>- Commit</p>
<br />
<p>On December 29th, 2011, 10:48 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2011, 10:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Immediately spotted ResizeEffect::isActive() wasn't implemented and \
did that as well. I recommend having this in 4.8 and best before a pot. second rc.
Function is tiny and does nothing unless we tell the user to call that, but might \
help on debugging and i myself wanted to check whether my code caught the exit more \
than once as well.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, prints "kwin4_effect_beclock" ;-)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=(CC)">(CC)</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=288948">288948</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=290025">290025</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(8c793ea)</span></li>
<li>kwin/effects.h <span style="color: grey">(6530871)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(e388b33)</span></li>
<li>kwin/effects/resize/resize.h <span style="color: grey">(88d29db)</span></li>
<li>kwin/org.kde.KWin.xml <span style="color: grey">(bd993ed)</span></li>
<li>kwin/workspace.h <span style="color: grey">(6069324)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103572/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic