'Re: Review Request: make the presentwindows effect more appealing'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: make the presentwindows effect more appealing
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-01-02 18:01:06
Message-ID: 20120102180106.21677.8810 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Jan. 2, 2012, 5:54 p.m., Commit Hook wrote:
> > This review has been submitted with commit 629e8d3885129db2be19bd313e07=
d6fa02caddc1 by Thomas L=C3=BCbking to branch master.

No has not - added wrong RR id....

- Thomas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103528/#review9463
-----------------------------------------------------------

On Dec. 24, 2011, 9:05 p.m., Philipp Knechtges wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103528/
> -----------------------------------------------------------
> =

> (Updated Dec. 24, 2011, 9:05 p.m.)
> =

> =

> Review request for kwin, Thomas L=C3=BCbking and Martin Gr=C3=A4=C3=9Flin.
> =

> =

> Description
> -------
> =

> This patch changes the highlighting behavior of the presentwindows
> effect such that the following criteria are met:
> =

> Assume that the highlighting is given as a function f that maps
> a rectangle r1 onto a rectangle r2, then
> - r2 should always be a superset of r1
> - if the center of r1 conincides with the screen area center so should
>   the center of r2
> - r2 should always be a subset of the screen area
> =

> Given the fact that highlighting is not optional and this is a rather sma=
ll patch, I would
> like to push it to the 4.8 branch.
> =

> =

> Diffs
> -----
> =

>   kwin/effects/presentwindows/presentwindows.cpp 52b713a =

> =

> Diff: http://git.reviewboard.kde.org/r/103528/diff/diff
> =

> =

> Testing
> -------
> =

> it works as expected
> =

> =

> Thanks,
> =

> Philipp Knechtges
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103528/">http://git.reviewboard.kde.org/r/103528/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On January 2nd, 2012, 5:54 p.m., <b>Commit \
Hook</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
629e8d3885129db2be19bd313e07d6fa02caddc1 by Thomas Lübking to branch master.</pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No has not - added wrong \
RR id....</pre> <br />

<p>- Thomas</p>

<br />
<p>On December 24th, 2011, 9:05 p.m., Philipp Knechtges wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Thomas Lübking and Martin Gräßlin.</div>
<div>By Philipp Knechtges.</div>

<p style="color: grey;"><i>Updated Dec. 24, 2011, 9:05 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch changes the highlighting behavior of the presentwindows \
effect such that the following criteria are met:

Assume that the highlighting is given as a function f that maps
a rectangle r1 onto a rectangle r2, then
- r2 should always be a superset of r1
- if the center of r1 conincides with the screen area center so should
  the center of r2
- r2 should always be a subset of the screen area

Given the fact that highlighting is not optional and this is a rather small patch, I \
would like to push it to the 4.8 branch.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it works as expected</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(52b713a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103528/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 