[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Disable Lanczos and Blur for fgrlx
From: "Commit Hook" <null () kde ! org>
Date: 2011-12-31 7:56:44
Message-ID: 20111231075644.12494.58416 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103556/#review9392
-----------------------------------------------------------
This review has been submitted with commit 8ecd9befaf80cdf5963b7ef24588679db7515b63 \
by Martin Gräßlin to branch KDE/4.8.
- Commit Hook
On Dec. 27, 2011, 6:31 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103556/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2011, 6:31 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> I'm sick of seeing all the fglrx crashes in my inbox. Let's disable the ARB shaders \
> in lanczos and blur in case of fglrx. I don't like to remove the functionality just \
> because it is breaking on some and not on all setups, but it's probably the best \
> idea.
>
> This addresses bugs 270818 and 286795.
> http://bugs.kde.org/show_bug.cgi?id=270818
> http://bugs.kde.org/show_bug.cgi?id=286795
>
>
> Diffs
> -----
>
> kwin/effects/blur/blur.cpp b394ff3
> kwin/lanczosfilter.cpp 210b324
>
> Diff: http://git.reviewboard.kde.org/r/103556/diff/diff
>
>
> Testing
> -------
>
> it compiles - missing hardware at the moment to test it.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103556/">http://git.reviewboard.kde.org/r/103556/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 8ecd9befaf80cdf5963b7ef24588679db7515b63 by Martin Gräßlin to \
branch KDE/4.8.</pre> <br />
<p>- Commit</p>
<br />
<p>On December 27th, 2011, 6:31 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2011, 6:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm sick of seeing all the fglrx crashes in my inbox. Let's \
disable the ARB shaders in lanczos and blur in case of fglrx. I don't like to \
remove the functionality just because it is breaking on some and not on all setups, \
but it's probably the best idea.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it compiles - missing hardware at the moment to test it.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=270818">270818</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=286795">286795</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/blur/blur.cpp <span style="color: grey">(b394ff3)</span></li>
<li>kwin/lanczosfilter.cpp <span style="color: grey">(210b324)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103556/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic