[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: force scaled highlighted window in present
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-12-30 14:46:49
Message-ID: 20111230144649.5209.79811 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 30, 2011, 11:57 a.m., Philipp Knechtges wrote:
> > kwin/effects/presentwindows/presentwindows.cpp, line 374
> > <http://git.reviewboard.kde.org/r/103574/diff/1/?file=45103#file45103line374>
> >
> > Given the fact that df and tScale are floats one should probably use 1.0f and 0.5f.
Actually both to prevent float -> double -> float
> On Dec. 30, 2011, 11:57 a.m., Philipp Knechtges wrote:
> > kwin/effects/presentwindows/presentwindows.cpp, lines 377-384
> > <http://git.reviewboard.kde.org/r/103574/diff/1/?file=45103#file45103line377>
> >
> > codingstyle :)
I'm not gonna add braces around (these) one-liners - fixed it otherwise :-p
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103574/#review9372
-----------------------------------------------------------
On Dec. 30, 2011, 12:24 a.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103574/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2011, 12:24 a.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> see https://git.reviewboard.kde.org/r/103528
>
>
> Diffs
> -----
>
> kwin/effects/presentwindows/presentwindows.cpp 52b713a
>
> Diff: http://git.reviewboard.kde.org/r/103574/diff/diff
>
>
> Testing
> -------
>
> yupp
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103574/">http://git.reviewboard.kde.org/r/103574/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 30th, 2011, 11:57 a.m., <b>Philipp \
Knechtges</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103574/diff/1/?file=45103#file45103line374" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/presentwindows/presentwindows.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PresentWindowsEffect::paintWindow(EffectWindow *w, int mask, QRegion region, \
WindowPaintData &data)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">374</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n"><span class="hl">QPoint</span></span><span \
class="hl"> </span><span class="n"><span class="hl">ac</span></span> <span \
class="o">=</span> <span class="n"><span class="hl">area</span></span><span \
class="p"><span class="hl">.</span></span><span class="n"><span \
class="hl">center</span></span><span class="p"><span \
class="hl">()</span>;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">374</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> \
<span class="kt"><span class="hl">float</span></span><span class="hl"> </span><span \
class="n"><span class="hl">df</span></span> <span class="o">=</span> <span \
class="p"><span class="hl">(</span></span><span class="n"><span \
class="hl">tScale</span></span><span class="o"><span class="hl">-</span></span><span \
class="mf"><span class="hl">1.0</span></span><span class="p"><span \
class="hl">)</span></span><span class="o"><span class="hl">*</span></span><span \
class="mf"><span class="hl">0.5</span></span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Given the fact that df \
and tScale are floats one should probably use 1.0f and 0.5f.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually \
both to prevent float -> double -> float</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 30th, 2011, 11:57 a.m., <b>Philipp \
Knechtges</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103574/diff/1/?file=45103#file45103line377" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/presentwindows/presentwindows.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PresentWindowsEffect::paintWindow(EffectWindow *w, int mask, QRegion region, \
WindowPaintData &data)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">377</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">tRect</span><span \
class="p">.</span><span class="n">left</span><span class="p">()</span> <span \
class="o"><</span> <span class="n">area</span><span class="p">.</span><span \
class="n">left</span><span class="p">())</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">378</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">tRect</span><span class="p">.</span><span \
class="n">moveLeft</span><span class="p">(</span><span class="n">area</span><span \
class="p">.</span><span class="n">left</span><span class="p">());</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">379</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">tRect</span><span \
class="p">.</span><span class="n">top</span><span class="p">()</span> <span \
class="o"><</span> <span class="n">area</span><span class="p">.</span><span \
class="n">top</span><span class="p">())</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">380</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">tRect</span><span class="p">.</span><span \
class="n">moveTop</span><span class="p">(</span><span class="n">area</span><span \
class="p">.</span><span class="n">top</span><span class="p">());</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">381</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">tRect</span><span \
class="p">.</span><span class="n">right</span><span class="p">()</span> <span \
class="o">></span> <span class="n">area</span><span class="p">.</span><span \
class="n">right</span><span class="p">())</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">382</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">tRect</span><span class="p">.</span><span \
class="n">moveRight</span><span class="p">(</span><span class="n">area</span><span \
class="p">.</span><span class="n">right</span><span class="p">());</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">383</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">tRect</span><span \
class="p">.</span><span class="n">bottom</span><span class="p">()</span> <span \
class="o">></span> <span class="n">area</span><span class="p">.</span><span \
class="n">bottom</span><span class="p">())</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">384</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">tRect</span><span class="p">.</span><span \
class="n">moveBottom</span><span class="p">(</span><span class="n">area</span><span \
class="p">.</span><span class="n">bottom</span><span class="p">());</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">codingstyle :)</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not \
gonna add braces around (these) one-liners - fixed it otherwise :-p</pre> <br />
<p>- Thomas</p>
<br />
<p>On December 30th, 2011, 12:24 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2011, 12:24 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see https://git.reviewboard.kde.org/r/103528</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yupp</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(52b713a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103574/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic