[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Fix window position after compositor polluted it
From: "Commit Hook" <null () kde ! org>
Date: 2011-12-18 18:52:45
Message-ID: 20111218185245.13095.42552 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103391/#review9058
-----------------------------------------------------------
This review has been submitted with commit 5dc917c4a3998053e793920e11375180c50675b4 \
by Thomas Lübking to branch master.
- Commit Hook
On Dec. 12, 2011, 2:25 a.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103391/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2011, 2:25 a.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> That it does.
> We may find a way to schedule the compositing setup _after_ the placement, but for \
> now, resetting the position is sufficient.
>
> This addresses bug 278981.
> http://bugs.kde.org/show_bug.cgi?id=278981
>
>
> Diffs
> -----
>
> kwin/composite.cpp 2fddb33
>
> Diff: http://git.reviewboard.kde.org/r/103391/diff/diff
>
>
> Testing
> -------
>
> yupp, textcase to bug and:
>
>
> #include <stdio.h>
> #include <stdlib.h>
> #include <X11/Xlib.h>
> #include <X11/Xutil.h>
>
> Display *display;
> int screen;
> Window root, window1, window2;
> XEvent event;
>
> int main(int argc, char *argv[])
> {
> display=XOpenDisplay(NULL);
> screen=DefaultScreen(display);
> root=DefaultRootWindow(display);
>
> /* create window and all related resources */
> XSetWindowAttributes attr;
> attr.win_gravity = StaticGravity;
> window1 = XCreateWindow(display, root, 50, 50, 640, 480, 0, DefaultDepth(display, \
> screen), InputOutput, DefaultVisual(display, screen), CWWinGravity, &attr); \
> XSizeHints sh; sh.x = 50; sh.y = 50;
> sh.win_gravity = StaticGravity;
> sh.flags |= PWinGravity|PPosition;
> XSetWMNormalHints(display, window1, &sh);
> XSync(display, False);
> XMapWindow(display, window1);
> XSync(display, False);
>
>
> // XUnmapWindow(display, window1);
> // XSync(display, False);
> // XMapWindow(display, window1);
> // XSync(display, False);
> while(1)
> usleep(20000000);
> }
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103391/">http://git.reviewboard.kde.org/r/103391/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 5dc917c4a3998053e793920e11375180c50675b4 by Thomas Lübking to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On December 12th, 2011, 2:25 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 12, 2011, 2:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">That it does. We may find a way to schedule the compositing setup \
_after_ the placement, but for now, resetting the position is sufficient.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yupp, textcase to bug and:
#include <stdio.h>
#include <stdlib.h>
#include <X11/Xlib.h>
#include <X11/Xutil.h>
Display *display;
int screen;
Window root, window1, window2;
XEvent event;
int main(int argc, char *argv[])
{
display=XOpenDisplay(NULL);
screen=DefaultScreen(display);
root=DefaultRootWindow(display);
/* create window and all related resources */
XSetWindowAttributes attr;
attr.win_gravity = StaticGravity;
window1 = XCreateWindow(display, root, 50, 50, 640, 480, 0, DefaultDepth(display, \
screen), InputOutput, DefaultVisual(display, screen), CWWinGravity, &attr); \
XSizeHints sh; sh.x = 50; sh.y = 50;
sh.win_gravity = StaticGravity;
sh.flags |= PWinGravity|PPosition;
XSetWMNormalHints(display, window1, &sh);
XSync(display, False);
XMapWindow(display, window1);
XSync(display, False);
// XUnmapWindow(display, window1);
// XSync(display, False);
// XMapWindow(display, window1);
// XSync(display, False);
while(1)
usleep(20000000);
}
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=278981">278981</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(2fddb33)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103391/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic