'Re: Review Request: Support minimized windows in Highlight windows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Support minimized windows in Highlight windows
From:       "Commit Hook" <null () kde ! org>
Date:       2011-12-18 18:52:45
Message-ID: 20111218185245.13094.20922 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103404/#review9057
-----------------------------------------------------------

This review has been submitted with commit 7c5dcf74408cac65666548fc93094c8e19810330 \
by Thomas Lübking to branch master.

- Commit Hook

On Dec. 13, 2011, 6:34 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103404/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2011, 6:34 p.m.)
> 
> 
> Review request for kwin and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> No idea why they were ignored (but for blank thumbnails? However a general and \
> rather minor issue) 
> also
> - replace QHash::operator[]
> - replace double by float (-> ARM efficiency, and we don't need that precision)
> - weaken some value checks ("== 1.0f" -> "< 0.98", faster than qFuzzyComapre and \
>                 nobody can spot 2% opacity in an animation)
> - fix last paint of hiding windows (the w->addRepaintFull() trap)
> -> the padding is arbitrary, the lib pot. needs the decorationRect exported?!
> 
> 
> Diffs
> -----
> 
> kwin/effects/highlightwindow/highlightwindow.h fa23965 
> kwin/effects/highlightwindow/highlightwindow.cpp 2174033 
> 
> Diff: http://git.reviewboard.kde.org/r/103404/diff/diff
> 
> 
> Testing
> -------
> 
> Yes, Highlight windows still works, minimized windows show up and hide on alt+tab
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103404/">http://git.reviewboard.kde.org/r/103404/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 7c5dcf74408cac65666548fc93094c8e19810330 by Thomas Lübking to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On December 13th, 2011, 6:34 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Dec. 13, 2011, 6:34 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No idea why they were ignored (but for blank thumbnails? However a \
general and rather minor issue)

also
- replace QHash::operator[]
- replace double by float (-&gt; ARM efficiency, and we don&#39;t need that \
                precision)
- weaken some value checks (&quot;== 1.0f&quot; -&gt; &quot;&lt; 0.98&quot;, faster \
                than qFuzzyComapre and nobody can spot 2% opacity in an animation)
- fix last paint of hiding windows (the w-&gt;addRepaintFull() trap)
  -&gt; the padding is arbitrary, the lib pot. needs the decorationRect exported?!
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, Highlight windows still works, minimized windows show up and hide \
on alt+tab</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/highlightwindow/highlightwindow.h <span style="color: \
grey">(fa23965)</span></li>

 <li>kwin/effects/highlightwindow/highlightwindow.cpp <span style="color: \
grey">(2174033)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103404/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 