'Re: Review Request: add graphicssystem config gui'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: add graphicssystem config gui
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2011-12-18 17:27:02
Message-ID: 20111218172702.7407.91420 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103431/#review9051
-----------------------------------------------------------

If you get the string freeze exception I'm mostly fine with it. But given t=
hat we are already late in the cycle and it's a technical text I'd vote for=
 delay to next cycle.

kwin/kcmkwin/kwincompositing/main.ui
<http://git.reviewboard.kde.org/r/103431/#comment7501>

    What's the label actually saying? My HTML parsing skills start to fail =
;-)

- Martin Gr=C3=A4=C3=9Flin

On Dec. 16, 2011, 5:24 p.m., Thomas L=C3=BCbking wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103431/
> -----------------------------------------------------------
> =

> (Updated Dec. 16, 2011, 5:24 p.m.)
> =

> =

> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =

> =

> Description
> -------
> =

> a label and a groupbox below the compositing backend.
> when the user changes the backend to xrender, "native" is set implicitly =
(but can be unset)
> =

> =

> Diffs
> -----
> =

>   kwin/kcmkwin/kwincompositing/main.h d993775 =

>   kwin/kcmkwin/kwincompositing/main.cpp 434a2a1 =

>   kwin/kcmkwin/kwincompositing/main.ui 0a63e9f =

> =

> Diff: http://git.reviewboard.kde.org/r/103431/diff/diff
> =

> =

> Testing
> -------
> =

> yes, swapped systems - see https://git.reviewboard.kde.org/r/103430/
> =

> =

> Thanks,
> =

> Thomas L=C3=BCbking
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103431/">http://git.reviewboard.kde.org/r/103431/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you get the string \
freeze exception I&#39;m mostly fine with it. But given that we are already late in \
the cycle and it&#39;s a technical text I&#39;d vote for delay to next cycle.</pre>  \
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103431/diff/1/?file=43542#file43542line533" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/kcmkwin/kwincompositing/main.ui</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">533</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
&lt;string&gt;&amp;lt;!DOCTYPE HTML PUBLIC &amp;quot;-//W3C//DTD HTML \
4.0//EN&amp;quot; &amp;quot;http://www.w3.org/TR/REC-html40/strict.dtd&amp;quot;&amp;gt;</pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">534</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">&amp;lt;html&amp;gt;&amp;lt;head&amp;gt;&amp;lt;meta \
name=&amp;quot;qrichtext&amp;quot; content=&amp;quot;1&amp;quot; \
/&amp;gt;&amp;lt;style type=&amp;quot;text/css&amp;quot;&amp;gt;</pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">535</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">p, li { \
white-space: pre-wrap; }</pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">536</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">&amp;lt;/style&amp;gt;&amp;lt;/head&amp;gt;&amp;lt;body style=&amp;quot; \
font-family:&#39;Segoe&#39;; font-size:8pt; font-weight:400; \
font-style:normal;&amp;quot;&amp;gt;</pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">537</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">&amp;lt;p \
style=&amp;quot; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px;&amp;quot;&amp;gt;It is \
&amp;lt;span style=&amp;quot; font-weight:600;&amp;quot;&amp;gt;strongly \
recommended&amp;lt;/span&amp;gt; to use the &amp;lt;span style=&amp;quot; \
font-weight:600;&amp;quot;&amp;gt;native&amp;lt;/span&amp;gt; system when using the \
the &amp;lt;span style=&amp;quot; \
font-weight:600;&amp;quot;&amp;gt;XRender&amp;lt;/span&amp;gt; \
backend.&amp;lt;/p&amp;gt;</pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">538</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">&amp;lt;p \
style=&amp;quot;-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px;&amp;quot;&amp;gt;&amp;lt;/p&amp;gt;</pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">539</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">&amp;lt;p \
style=&amp;quot; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px;&amp;quot;&amp;gt;On the other \
hand, many decorations perform better with the &amp;lt;span style=&amp;quot; \
font-weight:600;&amp;quot;&amp;gt;raster&amp;lt;/span&amp;gt; system on the \
&amp;lt;span style=&amp;quot; font-weight:600;&amp;quot;&amp;gt;default and generally \
preferred OpenGL&amp;lt;/span&amp;gt; backend (though some don&#39;t - also the \
impact here can be anything between &amp;amp;quot;slight&amp;amp;quot; and \
&amp;amp;quot;incredible&amp;amp;quot; depending on the GPU and \
driver)&amp;lt;/p&amp;gt;&amp;lt;/body&amp;gt;&amp;lt;/html&amp;gt;&lt;/string&gt;</pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What&#39;s \
the label actually saying? My HTML parsing skills start to fail ;-)</pre> </div>
<br />

<p>- Martin</p>

<br />
<p>On December 16th, 2011, 5:24 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Dec. 16, 2011, 5:24 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">a label and a groupbox below the compositing backend. when the user \
changes the backend to xrender, &quot;native&quot; is set implicitly (but can be \
unset)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, swapped systems - see \
https://git.reviewboard.kde.org/r/103430/</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/kcmkwin/kwincompositing/main.h <span style="color: \
grey">(d993775)</span></li>

 <li>kwin/kcmkwin/kwincompositing/main.cpp <span style="color: \
grey">(434a2a1)</span></li>

 <li>kwin/kcmkwin/kwincompositing/main.ui <span style="color: \
grey">(0a63e9f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103431/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 