[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Add support for graphicssystem selection
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2011-12-18 17:23:54
Message-ID: 20111218172354.7151.39359 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103430/#review9050
-----------------------------------------------------------
kwin/composite.cpp
<http://git.reviewboard.kde.org/r/103430/#comment7500>
that's a good idea. Finally we see in the GUI what is actually used.
kwin/main.cpp
<http://git.reviewboard.kde.org/r/103430/#comment7499>
should we honor an explicit --graphicssystem command line switch?
- Martin Gräßlin
On Dec. 16, 2011, 5:21 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103430/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2011, 5:21 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> As discussed, the performance of the raster graphicssystem on the xrender backend \
> is -independent of the decoration- lousy on at least nvidia and intel and likely \
> anywhere else. On the other hand, several decos have a strong preference for the \
> raster system (probably because of QGradient defects - no, not fixable upstream. \
> driver issue. code is there but not used ...)
> The patch allows to configure the system (stronger than QT_GRAPHICSSYSTEM \
> environment or qmake variable, but weaker than --graphicssystem) and also \
> preselects "native" when xrender is used and raster is not explicitly selected.
> For this purpose the patch also writes back the compositing backend on fallback for \
> OpenGL issues.
>
> Diffs
> -----
>
> kwin/composite.cpp 2fddb33
> kwin/libkwineffects/kwinglobals.cpp 69fc99a
> kwin/main.cpp 3773063
> kwin/workspace.h 6069324
> kwin/workspace.cpp 3c67ae6
>
> Diff: http://git.reviewboard.kde.org/r/103430/diff/diff
>
>
> Testing
> -------
>
> Yes:
> - broke my OpenGL ("yes, have sw rasterizer" ;-) and let me run into xrender \
> failsafe with preconfigured raster system
> - removed graphicssystem config and started kwin on xrender with \
> QT_GRAPHICSSYSTEM=raster, successfully ignored
> - swapped graphicssystems and backend in all possible configs, see kcm patch
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103430/">http://git.reviewboard.kde.org/r/103430/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103430/diff/1/?file=43535#file43535line236" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/composite.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Workspace::finishCompositing()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">236</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">config</span><span class="p">.</span><span class="n">writeEntry</span><span \
class="p">(</span><span class="s">"Backend"</span><span class="p">,</span> \
<span class="s">"XRender"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">that's \
a good idea. Finally we see in the GUI what is actually used.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103430/diff/1/?file=43537#file43537line420" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/main.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KDE_EXPORT int kdemain(int argc, char * argv[])</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">420</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QApplication</span><span class="o">::</span><span \
class="n">setGraphicsSystem</span><span class="p">(</span><span \
class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="s">"GraphicsSystem"</span><span \
class="p">,</span> <span class="n">preferredSystem</span><span \
class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should we \
honor an explicit --graphicssystem command line switch?</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On December 16th, 2011, 5:21 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2011, 5:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As discussed, the performance of the raster graphicssystem on the \
xrender backend is -independent of the decoration- lousy on at least nvidia and intel \
and likely anywhere else. On the other hand, several decos have a strong preference \
for the raster system (probably because of QGradient defects - no, not fixable \
upstream. driver issue. code is there but not used ...)
The patch allows to configure the system (stronger than QT_GRAPHICSSYSTEM environment \
or qmake variable, but weaker than --graphicssystem) and also preselects \
"native" when xrender is used and raster is not explicitly selected.
For this purpose the patch also writes back the compositing backend on fallback for \
OpenGL issues.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes:
- broke my OpenGL ("yes, have sw rasterizer" ;-) and let me run into \
xrender failsafe with preconfigured raster system
- removed graphicssystem config and started kwin on xrender with \
QT_GRAPHICSSYSTEM=raster, successfully ignored
- swapped graphicssystems and backend in all possible configs, see kcm patch</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(2fddb33)</span></li>
<li>kwin/libkwineffects/kwinglobals.cpp <span style="color: \
grey">(69fc99a)</span></li>
<li>kwin/main.cpp <span style="color: grey">(3773063)</span></li>
<li>kwin/workspace.h <span style="color: grey">(6069324)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(3c67ae6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103430/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic