'Re: Review Request: [Patch 1/2] Fix Sliding Popups'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: [Patch 1/2] Fix Sliding Popups
From:       "Commit Hook" <null () kde ! org>
Date:       2011-12-10 21:39:57
Message-ID: 20111210213957.4744.55910 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103366/#review8862
-----------------------------------------------------------

This review has been submitted with commit 5960ae9846c333ef381a817af9d63776c4ddc201 \
by Martin Gräßlin to branch KDE/4.7.

- Commit Hook

On Dec. 9, 2011, 5:18 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103366/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2011, 5:18 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> When the offset was not explicitly specified, the actual distance of the window to \
> the nearest screen edge should be used as offset. This was calculated incorrectly \
> resulting in broken code in the kwin effect. 
> With this change a new "default" is introduced as -1 which is interpreted by kwin \
> as kwin has to calculate the correct offset. Now it would be possible to do this in \
> the library and pass the correct offset, but the library would have to create a \
> QDesktopWidget just to calculate the screen geometry. KWin on the other hand knows \
> the screen size, so having the default is IMHO better. 
> Adjustments to kwin come in next patch for kde-workspace
> 
> 
> This addresses bug 287602.
> http://bugs.kde.org/show_bug.cgi?id=287602
> 
> 
> Diffs
> -----
> 
> plasma/windoweffects.cpp ce41176 
> 
> Diff: http://git.reviewboard.kde.org/r/103366/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103366/">http://git.reviewboard.kde.org/r/103366/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 5960ae9846c333ef381a817af9d63776c4ddc201 by Martin Gräßlin to \
branch KDE/4.7.</pre>  <br />

<p>- Commit</p>

<br />
<p>On December 9th, 2011, 5:18 p.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Dec. 9, 2011, 5:18 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When the offset was not explicitly specified, the actual distance of the \
window to the nearest screen edge should be used as offset. This was calculated \
incorrectly resulting in broken code in the kwin effect.

With this change a new &quot;default&quot; is introduced as -1 which is interpreted \
by kwin as kwin has to calculate the correct offset. Now it would be possible to do \
this in the library and pass the correct offset, but the library would have to create \
a QDesktopWidget just to calculate the screen geometry. KWin on the other hand knows \
the screen size, so having the default is IMHO better.

Adjustments to kwin come in next patch for kde-workspace</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=287602">287602</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/windoweffects.cpp <span style="color: grey">(ce41176)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103366/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 