'Re: Review Request: sanitize closed screenshot window'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: sanitize closed screenshot window
From:       "Commit Hook" <null () kde ! org>
Date:       2011-12-10 20:27:57
Message-ID: 20111210202757.31684.21403 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103350/#review8859
-----------------------------------------------------------

This review has been submitted with commit 57bd753c0f2f980b41d4ef5df812866f26c56e74 \
by Thomas Lübking to branch master.

- Commit Hook

On Dec. 7, 2011, 9:25 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103350/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2011, 9:25 p.m.)
> 
> 
> Review request for kwin and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> i doubt this will fix the bug but could think of sharing the same source because \
> the cliked window is gone when the paint takes place and you get a beauty black \
> nothing - could also be for a looong fade out time or so. Will check on that one \
> tonight. 
> 
> This addresses bug 288271(?).
> http://bugs.kde.org/show_bug.cgi?id=288271(?)
> 
> 
> Diffs
> -----
> 
> kwin/effects/screenshot/screenshot.h 0b9e613 
> kwin/effects/screenshot/screenshot.cpp 6b9fcee 
> 
> Diff: http://git.reviewboard.kde.org/r/103350/diff/diff
> 
> 
> Testing
> -------
> 
> nope. not - the - least.
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103350/">http://git.reviewboard.kde.org/r/103350/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 57bd753c0f2f980b41d4ef5df812866f26c56e74 by Thomas Lübking to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On December 7th, 2011, 9:25 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Dec. 7, 2011, 9:25 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">i doubt this will fix the bug but could think of sharing the same source \
because the cliked window is gone when the paint takes place and you get a beauty \
black nothing - could also be for a looong fade out time or so. Will check on that \
one tonight.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">nope. not - the - least.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=288271(?)">288271(?)</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/screenshot/screenshot.h <span style="color: \
grey">(0b9e613)</span></li>

 <li>kwin/effects/screenshot/screenshot.cpp <span style="color: \
grey">(6b9fcee)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103350/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 