[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Add two options regarding mouse invocation when
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-11-25 20:15:03
Message-ID: 20111125201503.8428.21625 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102371/
-----------------------------------------------------------
(Updated Nov. 25, 2011, 8:15 p.m.)
Review request for kwin and Martin Gräßlin.
Changes
-------
- removed mouseToNextWindow
- disabled GUI (it's still there, but hidden and the i18n call is camouflaged)
- ignore desktops (it's called "prefer mouse", not "act as FSUM")
- cloned code for setCurrentDesktop (bug #159989) which does not call \
activateNextClient ... (4.9 TODO: change that ;-)
Description
-------
Passing the on the focus to the client under the mouse makes sense in a mouse driven \
focus scheme like FFM (but i didn't restrict it, so it can be used with CTF as well) \
Whether ensureing the pointer to be under the currently active window makes sense or \
is sane, i don't know. I know that E17 has it, that it's a complement to the above, \
and that it's pretty much a one liner. *shrug*
This addresses bugs 80897 and 159989.
http://bugs.kde.org/show_bug.cgi?id=80897
http://bugs.kde.org/show_bug.cgi?id=159989
Diffs (updated)
-----
kwin/activation.cpp b50a325
kwin/kcmkwin/kwinoptions/windows.h f7a8658
kwin/kcmkwin/kwinoptions/windows.cpp 84c3cb5
kwin/options.h 4dab3ac
kwin/options.cpp 19c3ee5
kwin/workspace.cpp 6a8e2df
Diff: http://git.reviewboard.kde.org/r/102371/diff/diff
Testing
-------
Yes, focus end up under mouse w/ and in focus chain w/o. Cursor jumps correctly in a \
single screen setup (moeved back the other screen - but given that xrandr is just a \
HUUUGE screen area, i doubt it makes any difference)
Thanks,
Thomas Lübking
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102371/">http://git.reviewboard.kde.org/r/102371/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2011, 8:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- removed mouseToNextWindow
- disabled GUI (it's still there, but hidden and the i18n call is camouflaged)
- ignore desktops (it's called "prefer mouse", not "act as \
FSUM")
- cloned code for setCurrentDesktop (bug #159989) which does not call \
activateNextClient ... (4.9 TODO: change that ;-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Passing the on the focus to the client under the mouse makes sense in a \
mouse driven focus scheme like FFM (but i didn't restrict it, so it can be used \
with CTF as well) Whether ensureing the pointer to be under the currently active \
window makes sense or is sane, i don't know. I know that E17 has it, that \
it's a complement to the above, and that it's pretty much a one liner. \
*shrug*</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, focus end up under mouse w/ and in focus chain w/o. Cursor jumps \
correctly in a single screen setup (moeved back the other screen - but given that \
xrandr is just a HUUUGE screen area, i doubt it makes any difference)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=80897">80897</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=159989">159989</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/activation.cpp <span style="color: grey">(b50a325)</span></li>
<li>kwin/kcmkwin/kwinoptions/windows.h <span style="color: \
grey">(f7a8658)</span></li>
<li>kwin/kcmkwin/kwinoptions/windows.cpp <span style="color: \
grey">(84c3cb5)</span></li>
<li>kwin/options.h <span style="color: grey">(4dab3ac)</span></li>
<li>kwin/options.cpp <span style="color: grey">(19c3ee5)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(6a8e2df)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102371/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic