'Review Request: fix xrender scaled + shadow bug'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: fix xrender scaled + shadow bug
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2011-09-25 19:03:01
Message-ID: 20110925190301.8304.89953 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102703/
-----------------------------------------------------------

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

Description
-------

The decorationRect wasn't calculated for some windows but (in indirect blit=
ting case) still used, as a result scaling popups with new shadows didn't w=
ork but w/o did.

Also i made the identity matrix static since there's no point in recalculat=
ing it over and over again.

Diffs
-----

  kwin/scene_xrender.cpp 8ed6f07 =

Diff: http://git.reviewboard.kde.org/r/102703/diff/diff

Testing
-------

Yes. There seems to be some off-by-one between toplevel and deleted, but th=
at might as well be the generic animation code.

Thanks,

Thomas L=C3=BCbking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102703/">http://git.reviewboard.kde.org/r/102703/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The decorationRect wasn&#39;t calculated for some windows but (in \
indirect blitting case) still used, as a result scaling popups with new shadows \
didn&#39;t work but w/o did.

Also i made the identity matrix static since there&#39;s no point in recalculating it \
over and over again.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes. There seems to be some off-by-one between toplevel and deleted, but \
that might as well be the generic animation code.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/scene_xrender.cpp <span style="color: grey">(8ed6f07)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102703/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 