[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: make Walk Through Desktops List work again
From: "Commit Hook" <null () kde ! org>
Date: 2011-09-10 10:41:46
Message-ID: 20110910104146.20105.48318 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102558/#review6372
-----------------------------------------------------------
This review has been submitted with commit 4f30f53cfa3ba2ad1cacf5e89579903bdd80049f \
by Jonathan Marten to branch master.
- Commit
On Sept. 9, 2011, 7:45 p.m., Jonathan Marten wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102558/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2011, 7:45 p.m.)
>
>
> Review request for kwin.
>
>
> Summary
> -------
>
> The Walk Through Desktops List and its corresponding Reverse action have not worked \
> for some time, see the bug report for further information. These changes seem to \
> fix the problem.
> Brief summary of the rationale for them:
>
> (1) A Kaction does not seem to emit (or no longer emits) the globalShortcutChanged \
> signal when it is initialised, therefore the slot \
> (slotWalkThroughDesktopsKeyChanged or similar) for recording the shortcut in the \
> internal member variable (m_cutWalkThroughDesktops or similar) does not get called \
> on KWin startup. This means that the shortcut will not work unless it is changed \
> in systemsettings and then changed back again. The variable is explictly \
> initialised by reading back the shortcut.
> (2) The 'shortcutSlot' specified for Walk Through Desktops was incorrect.
>
> (3) TabBox::setCurrentDesktop() does not actually change the desktop. Calling \
> Workspace::self()->setCurrentDesktop() appears to make it work.
>
> This addresses bug 279638.
> http://bugs.kde.org/show_bug.cgi?id=279638
>
>
> Diffs
> -----
>
> kwin/tabbox/tabbox.cpp eb75efd
>
> Diff: http://git.reviewboard.kde.org/r/102558/diff
>
>
> Testing
> -------
>
> Built kwin with these changes, checked operation of Walk Through Desktops List and \
> Reverse actions (bound to Ctrl+Tab, Ctrl+Shift+Tab).
>
> Thanks,
>
> Jonathan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102558/">http://git.reviewboard.kde.org/r/102558/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 4f30f53cfa3ba2ad1cacf5e89579903bdd80049f by Jonathan Marten to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On September 9th, 2011, 7:45 p.m., Jonathan Marten wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Sept. 9, 2011, 7:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The Walk Through Desktops List and its corresponding Reverse action have \
not worked for some time, see the bug report for further information. These changes \
seem to fix the problem.
Brief summary of the rationale for them:
(1) A Kaction does not seem to emit (or no longer emits) the globalShortcutChanged \
signal when it is initialised, therefore the slot (slotWalkThroughDesktopsKeyChanged \
or similar) for recording the shortcut in the internal member variable \
(m_cutWalkThroughDesktops or similar) does not get called on KWin startup. This \
means that the shortcut will not work unless it is changed in systemsettings and then \
changed back again. The variable is explictly initialised by reading back the \
shortcut.
(2) The 'shortcutSlot' specified for Walk Through Desktops was incorrect.
(3) TabBox::setCurrentDesktop() does not actually change the desktop. Calling \
Workspace::self()->setCurrentDesktop() appears to make it work.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built kwin with these changes, checked operation of Walk Through \
Desktops List and Reverse actions (bound to Ctrl+Tab, Ctrl+Shift+Tab).</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279638">279638</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/tabbox/tabbox.cpp <span style="color: grey">(eb75efd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102558/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic