'Re: Review Request: Fix tiling code, basically pointer handing'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Fix tiling code, basically pointer handing
From:       "Commit Hook" <null () kde ! org>
Date:       2011-09-10 7:39:55
Message-ID: 20110910073955.13217.40295 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102424/#review6369
-----------------------------------------------------------

This review has been submitted with commit 75021be9184da93c2410b37751bb0b9fdeb5de5a \
by Thomas Lübking to branch KDE/4.7.

- Commit

On Aug. 25, 2011, 12:27 a.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102424/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2011, 12:27 a.m.)
> 
> 
> Review request for kwin, Nikhil Shantanu Marathe and Martin Gräßlin.
> 
> 
> Summary
> -------
> 
> Code post-commit review & patch.
> Sorry if it sounds grumpy - it's late and i wanted to see a Loriot video instead.
> 
> I read across the tiling code. Looks valid otherewise (ie. the other unchecked \
> pointers should all be checked by the calling functions) 
> 
> This addresses bug 274223.
> http://bugs.kde.org/show_bug.cgi?id=274223
> 
> 
> Diffs
> -----
> 
> kwin/tile.cpp a188129 
> kwin/tiling.cpp 85b2227 
> kwin/tilinglayout.cpp 6e1152b 
> 
> Diff: http://git.reviewboard.kde.org/r/102424/diff
> 
> 
> Testing
> -------
> 
> Yes, Meta + f will just do nothing when no client is active.
> 
> 
> Thanks,
> 
> Thomas
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102424/">http://git.reviewboard.kde.org/r/102424/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 75021be9184da93c2410b37751bb0b9fdeb5de5a by Thomas Lübking to \
branch KDE/4.7.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 25th, 2011, 12:27 a.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Nikhil Shantanu Marathe and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Aug. 25, 2011, 12:27 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Code post-commit review &amp; patch. Sorry if it sounds grumpy - \
it&#39;s late and i wanted to see a Loriot video instead.

I read across the tiling code. Looks valid otherewise (ie. the other unchecked \
pointers should all be checked by the calling functions)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, Meta + f will just do nothing when no client is active.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=274223">274223</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/tile.cpp <span style="color: grey">(a188129)</span></li>

 <li>kwin/tiling.cpp <span style="color: grey">(85b2227)</span></li>

 <li>kwin/tilinglayout.cpp <span style="color: grey">(6e1152b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102424/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 