'Re: Review Request: check workspace position after screen change of'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: check workspace position after screen change of
From:       "Commit Hook" <null () kde ! org>
Date:       2011-08-23 21:45:59
Message-ID: 20110823214559.8657.40214 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102414/#review5956
-----------------------------------------------------------

This review has been submitted with commit 7142d5557d252f21ec739352708520e4d9fe64d4 \
by Thomas Lübking to branch master.

- Commit

On Aug. 22, 2011, 8:25 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102414/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2011, 8:25 p.m.)
> 
> 
> Review request for kwin and Martin Gräßlin.
> 
> 
> Summary
> -------
> 
> When the screen of a window is changed during a moveResize the maximizationMode is \
> honored (ie a maximized client will be maximized to the new screen) what aside \
> fixing the bug is imho an improvement over the former geometry driven behaviour \
> where the maximization state was just unset (in case the screen geometry didn't \
> fit) 
> Alongside this i raised the requirements for the patch for bug #279529 so that only \
> a resize will unset the maximization state but not a plain move because a) changing \
> the position does not change the maximum size condition (and the client can be \
> re/snapped to the borders) b) consistency with partial maximization (those clients \
> could alway be moved w/o altering the state ever since) c) the ability to keep the \
> state across screen changes ;-) 
> 
> This addresses bugs 279051 and 279529.
> http://bugs.kde.org/show_bug.cgi?id=279051
> http://bugs.kde.org/show_bug.cgi?id=279529
> 
> 
> Diffs
> -----
> 
> kwin/client.h c0a87db 
> kwin/geometry.cpp 56248ae 
> 
> Diff: http://git.reviewboard.kde.org/r/102414/diff
> 
> 
> Testing
> -------
> 
> Yes, works as expected.
> I btw. figured that the sendToScreen shortcut does not send clients to screens in \
> all cases (since it preserves the geometry while the screen number is driven by \
> geometry().center()) 
> 
> Thanks,
> 
> Thomas
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102414/">http://git.reviewboard.kde.org/r/102414/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 7142d5557d252f21ec739352708520e4d9fe64d4 by Thomas Lübking to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 22nd, 2011, 8:25 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Aug. 22, 2011, 8:25 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When the screen of a window is changed during a moveResize the \
maximizationMode is honored (ie a maximized client will be maximized to the new \
screen) what aside fixing the bug is imho an improvement over the former geometry \
driven behaviour where the maximization state was just unset (in case the screen \
geometry didn&#39;t fit)

Alongside this i raised the requirements for the patch for bug #279529 so that only a \
resize will unset the maximization state but not a plain move because a) changing the \
position does not change the maximum size condition (and the client can be re/snapped \
to the borders) b) consistency with partial maximization (those clients could alway \
be moved w/o altering the state ever since) c) the ability to keep the state across \
screen changes ;-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, works as expected. I btw. figured that the sendToScreen shortcut \
does not send clients to screens in all cases (since it preserves the geometry while \
the screen number is driven by geometry().center())</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=279051">279051</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=279529">279529</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.h <span style="color: grey">(c0a87db)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(56248ae)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102414/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 