From kwin Tue Aug 23 21:45:59 2011 From: "Commit Hook" Date: Tue, 23 Aug 2011 21:45:59 +0000 To: kwin Subject: Re: Review Request: check workspace position after screen change of Message-Id: <20110823214559.8657.40214 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=131413597727178 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3119997822709834268==" --===============3119997822709834268== Content-Type: multipart/alternative; boundary="===============3096459682701461796==" --===============3096459682701461796== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102414/#review5956 ----------------------------------------------------------- This review has been submitted with commit 7142d5557d252f21ec739352708520e4= d9fe64d4 by Thomas L=C3=BCbking to branch master. - Commit On Aug. 22, 2011, 8:25 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102414/ > ----------------------------------------------------------- > = > (Updated Aug. 22, 2011, 8:25 p.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Summary > ------- > = > When the screen of a window is changed during a moveResize the maximizati= onMode is honored (ie a maximized client will be maximized to the new scree= n) what aside fixing the bug is imho an improvement over the former geometr= y driven behaviour where the maximization state was just unset (in case the= screen geometry didn't fit) > = > Alongside this i raised the requirements for the patch for bug #279529 so= that only a resize will unset the maximization state but not a plain move = because > a) changing the position does not change the maximum size condition (and = the client can be re/snapped to the borders) > b) consistency with partial maximization (those clients could alway be mo= ved w/o altering the state ever since) > c) the ability to keep the state across screen changes ;-) > = > = > This addresses bugs 279051 and 279529. > http://bugs.kde.org/show_bug.cgi?id=3D279051 > http://bugs.kde.org/show_bug.cgi?id=3D279529 > = > = > Diffs > ----- > = > kwin/client.h c0a87db = > kwin/geometry.cpp 56248ae = > = > Diff: http://git.reviewboard.kde.org/r/102414/diff > = > = > Testing > ------- > = > Yes, works as expected. > I btw. figured that the sendToScreen shortcut does not send clients to sc= reens in all cases (since it preserves the geometry while the screen number= is driven by geometry().center()) > = > = > Thanks, > = > Thomas > = > --===============3096459682701461796== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102414/ 

This revie=
w has been submitted with commit 7142d5557d252f21ec739352708520e4d9fe64d4 b=
y Thomas L=C3=BCbking to branch master.

- Commit


On August 22nd, 2011, 8:25 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Thomas L=C3=BCbking.

Updated Aug. 22, 2011, 8:25 p.m.

Descripti= on 

When the screen of a window is changed during a moveResize t=
he maximizationMode is honored (ie a maximized client will be maximized to =
the new screen) what aside fixing the bug is imho an improvement over the f=
ormer geometry driven behaviour where the maximization state was just unset=
 (in case the screen geometry didn't fit)

Alongside this i raised the requirements for the patch for bug #279529 so t=
hat only a resize will unset the maximization state but not a plain move be=
cause
a) changing the position does not change the maximum size condition (and th=
e client can be re/snapped to the borders)
b) consistency with partial maximization (those clients could alway be move=
d w/o altering the state ever since)
c) the ability to keep the state across screen changes ;-)

Testing <= /h1> 
Yes, works as expected.
I btw. figured that the sendToScreen shortcut does not send clients to scre=
ens in all cases (since it preserves the geometry while the screen number i=
s driven by geometry().center())
Bugs: 279051, = 279529

Diffs=

  • kwin/client.h (c0a87db)
  • kwin/geometry.cpp (56248ae)

View Diff
--===============3096459682701461796==-- --===============3119997822709834268== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============3119997822709834268==--