'Re: Review Request: Optimizing Blur'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Optimizing Blur
From:       "Commit Hook" <null () kde ! org>
Date:       2011-07-14 12:24:58
Message-ID: 20110714122458.25480.98788 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101898/#review4726
-----------------------------------------------------------

This review has been submitted with commit 693444054a945da207684a49023635aa=
13c70715 by Philipp Knechtges to branch master.

- Commit

On July 13, 2011, 8:15 p.m., Philipp Knechtges wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101898/
> -----------------------------------------------------------
> =

> (Updated July 13, 2011, 8:15 p.m.)
> =

> =

> Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Fredrik H=C3=B6glun=
d.
> =

> =

> Summary
> -------
> =

> This patch adds the following capabilities:
> - now paintSimpleScreen (view my other review request 101846) can also dr=
aw blurred regions
> - we can do partial blur if the blurred region is occluded
> =

> =

> Diffs
> -----
> =

>   kwin/effects/blur/blur.h daed4db =

>   kwin/effects/blur/blur.cpp 8a50e07 =

> =

> Diff: http://git.reviewboard.kde.org/r/101898/diff
> =

> =

> Testing
> -------
> =

> only tested with the new version of paintSimpleScreen
> =

> =

> Thanks,
> =

> Philipp
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101898/">http://git.reviewboard.kde.org/r/101898/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 693444054a945da207684a49023635aa13c70715 by Philipp Knechtges \
to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 13th, 2011, 8:15 p.m., Philipp Knechtges wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Fredrik Höglund.</div>
<div>By Philipp Knechtges.</div>

<p style="color: grey;"><i>Updated July 13, 2011, 8:15 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">This patch adds the following capabilities:
- now paintSimpleScreen (view my other review request 101846) can also draw blurred \
                regions
- we can do partial blur if the blurred region is occluded</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">only tested with the new version of paintSimpleScreen</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/blur/blur.h <span style="color: grey">(daed4db)</span></li>

 <li>kwin/effects/blur/blur.cpp <span style="color: grey">(8a50e07)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101898/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 