[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Make blur work again for windows with
From: "Commit Hook" <null () kde ! org>
Date: 2011-07-14 17:18:36
Message-ID: 20110714171836.9351.78740 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101907/#review4730
-----------------------------------------------------------
This review has been submitted with commit f3443ab339ce448a347fa4fe4310f03d=
e577ee94 by Martin Gr=C3=A4=C3=9Flin to branch KDE/4.7.
- Commit
On July 10, 2011, 11:34 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101907/
> -----------------------------------------------------------
> =
> (Updated July 10, 2011, 11:34 a.m.)
> =
> =
> Review request for kwin, Fredrik H=C3=B6glund and Andreas Demmer.
> =
> =
> Summary
> -------
> =
> Fixes a regression with the dashboard effect: the blur behind setting was=
lost. Dashboard is a fullscreen effect, but does not do full repaints, so =
we need to add the "normal" blur handling for fullscreen effects if there i=
s a window which enforces blur behind even for fullscreen effects.
> =
> =
> I think the change should be save.
> =
> =
> Diffs
> -----
> =
> kwin/effects/blur/blur.cpp 8a50e07 =
> =
> Diff: http://git.reviewboard.kde.org/r/101907/diff
> =
> =
> Testing
> -------
> =
> Dashboard works again, other fullscreen effects + blur, too
> =
> =
> Thanks,
> =
> Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101907/">http://git.reviewboard.kde.org/r/101907/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit f3443ab339ce448a347fa4fe4310f03de577ee94 by Martin Gräßlin to \
branch KDE/4.7.</pre> <br />
<p>- Commit</p>
<br />
<p>On July 10th, 2011, 11:34 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Fredrik Höglund and Andreas Demmer.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated July 10, 2011, 11:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes a regression with the dashboard effect: the blur behind setting \
was lost. Dashboard is a fullscreen effect, but does not do full repaints, so we need \
to add the "normal" blur handling for fullscreen effects if there is a \
window which enforces blur behind even for fullscreen effects.
I think the change should be save.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Dashboard works again, other fullscreen effects + blur, too</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/blur/blur.cpp <span style="color: grey">(8a50e07)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101907/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic