'Review Request: Add Rule/Property based composite blocking [kdelibs'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Add Rule/Property based composite blocking [kdelibs
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2011-03-22 19:17:30
Message-ID: 20110322191730.29436.90231 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100921/
-----------------------------------------------------------

Review request for kdelibs and kwin.

Summary
-------

complementary patch for https://git.reviewboard.kde.org/r/100893
allows clients to block compositing at any time (to free resources) - inter=
esting for games, videoplayer, screensavers...

we'd try to get this into netwm (since martin suggested compiz might be abl=
e to suspend/resume as well, there's actually some chance for it ;-)
even if not in netwm spec, it will prevent clients from having to care abou=
t XPropertiy setting/getting

Diffs
-----

  kdeui/windowmanagement/kwindowsystem.h 034d7f1 =

  kdeui/windowmanagement/kwindowsystem_mac.cpp a08b443 =

  kdeui/windowmanagement/kwindowsystem_qws.cpp e8c3fb6 =

  kdeui/windowmanagement/kwindowsystem_win.cpp f2b2883 =

  kdeui/windowmanagement/kwindowsystem_x11.cpp 7427e77 =

  kdeui/windowmanagement/netwm.h 9a18db6 =

  kdeui/windowmanagement/netwm.cpp 214c10f =

  kdeui/windowmanagement/netwm_def.h b3ec529 =

  kdeui/windowmanagement/netwm_p.h 80eeda7 =

Diff: http://git.reviewboard.kde.org/r/100921/diff

Testing
-------

compiled, the query works (used from kwin) - the setter... "should" ;-)

Thanks,

Thomas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100921/">http://git.reviewboard.kde.org/r/100921/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and kwin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">complementary patch for https://git.reviewboard.kde.org/r/100893 allows \
clients to block compositing at any time (to free resources) - interesting for games, \
videoplayer, screensavers...

we&#39;d try to get this into netwm (since martin suggested compiz might be able to \
suspend/resume as well, there&#39;s actually some chance for it ;-) even if not in \
netwm spec, it will prevent clients from having to care about XPropertiy \
setting/getting</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiled, the query works (used from kwin) - the setter... \
&quot;should&quot; ;-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeui/windowmanagement/kwindowsystem.h <span style="color: \
grey">(034d7f1)</span></li>

 <li>kdeui/windowmanagement/kwindowsystem_mac.cpp <span style="color: \
grey">(a08b443)</span></li>

 <li>kdeui/windowmanagement/kwindowsystem_qws.cpp <span style="color: \
grey">(e8c3fb6)</span></li>

 <li>kdeui/windowmanagement/kwindowsystem_win.cpp <span style="color: \
grey">(f2b2883)</span></li>

 <li>kdeui/windowmanagement/kwindowsystem_x11.cpp <span style="color: \
grey">(7427e77)</span></li>

 <li>kdeui/windowmanagement/netwm.h <span style="color: grey">(9a18db6)</span></li>

 <li>kdeui/windowmanagement/netwm.cpp <span style="color: grey">(214c10f)</span></li>

 <li>kdeui/windowmanagement/netwm_def.h <span style="color: \
grey">(b3ec529)</span></li>

 <li>kdeui/windowmanagement/netwm_p.h <span style="color: grey">(80eeda7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100921/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 